* Fix a potential NullReferenceException in the InvocationInfo class

* Make FireAsync_TriggerWithMoreThanThreeParameters unit test culturally invariant. Otherwise it fails on some system locales.
dotnet-state-machine · Feb 4, 2024 · 0c11ccb · 0c11ccb
1 parent 66eee8f
commit 0c11ccb
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 2 deletions.
diff --git a/src/Stateless/Reflection/InvocationInfo.cs b/src/Stateless/Reflection/InvocationInfo.cs
@@ -63,9 +63,11 @@ public string Description
             {
                 if (_description != null)
                     return _description;
+                if (MethodName == null)
+                    return "<null>";
                 if (MethodName.IndexOfAny(new char[] { '<', '>', '`' }) >= 0)
                     return DefaultFunctionDescription;
-                return MethodName ?? "<null>";
+                return MethodName;
             }
         }
 

diff --git a/test/Stateless.Tests/AsyncActionsFixture.cs b/test/Stateless.Tests/AsyncActionsFixture.cs
@@ -5,6 +5,7 @@
 using System.Collections.Generic;
 
 using Xunit;
+using System.Globalization;
 
 namespace Stateless.Tests
 {
@@ -544,7 +545,8 @@ public async Task OnEntryFromAsync_WhenEnteringByAnotherTrigger_InvokesAction()
         [Fact]
         public async Task FireAsync_TriggerWithMoreThanThreeParameters()
         {
-            const string expectedParam = "42-Stateless-True-420.69-Y";
+            var decimalSeparator = CultureInfo.CurrentCulture.NumberFormat.NumberDecimalSeparator;
+            string expectedParam = $"42-Stateless-True-420{decimalSeparator}69-Y";
             string actualParam = null;
 
             var sm = new StateMachine<State, Trigger>(State.A);