Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

添加相似变换；移除 .NET6 的支持 #8

Merged
merged 6 commits into from
Nov 26, 2024
Merged

添加相似变换；移除 .NET6 的支持 #8

merged 6 commits into from
Nov 26, 2024

Conversation

SeWZC
Copy link
Collaborator

@SeWZC SeWZC commented Nov 26, 2024

No description provided.

@SeWZC SeWZC requested review from walterlv and lindexi November 26, 2024 09:02
lindexi
lindexi requested changes Nov 26, 2024
View reviewed changes
Copy link
Member

@lindexi lindexi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

构建爆了

Error: /home/runner/work/DotNetCampus.Numerics/DotNetCampus.Numerics/DotNetCampus.Numerics.Geometry/SimilarityTransformation2D.cs(34,9): error CS0501: 'SimilarityTransformation2D.Scaling.get' must declare a body because it is not marked abstract, extern, or partial [/home/runner/work/DotNetCampus.Numerics/DotNetCampus.Numerics/DotNetCampus.Numerics.Geometry/DotNetCampus.Numerics.Geometry.csproj]

Error: /home/runner/work/DotNetCampus.Numerics/DotNetCampus.Numerics/DotNetCampus.Numerics.Geometry/SimilarityTransformation2D.cs(32,19): error CS8050: Only auto-implemented properties can have initializers. [/home/runner/work/DotNetCampus.Numerics/DotNetCampus.Numerics/DotNetCampus.Numerics.Geometry/DotNetCampus.Numerics.Geometry.csproj]

walterlv
walterlv requested changes Nov 26, 2024
View reviewed changes
Directory.Build.props Outdated Show resolved Hide resolved
DotNetCampus.Numerics.Geometry/IBezierCurve.cs Outdated Show resolved Hide resolved
@SeWZC SeWZC requested review from walterlv and lindexi November 26, 2024 09:14
@SeWZC SeWZC merged commit 122c1bc into master Nov 26, 2024
1 check passed
@SeWZC SeWZC deleted the t/sewzc/similarity_transformation branch November 26, 2024 09:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lindexi lindexi lindexi approved these changes

@walterlv walterlv walterlv approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@SeWZC @walterlv @lindexi