Fix single mode #7
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
breakingthebuild
requested changes
Apr 11, 2019
Contributor
breakingthebuild
left a comment
breakingthebuild
left a comment
There was a problem hiding this comment.
Looking really good. Just had 2 minor questions/feedback
|
|
||
| private val openPositions: MutableSet<Int> = HashSet() | ||
| private var mode = Single | ||
| class SwipableCellHandler() { |
Contributor
There was a problem hiding this comment.
I think the empty constructor can be removed
| } | ||
|
|
||
| @JvmOverloads | ||
| fun reset(position: Int? = null) { |
Contributor
There was a problem hiding this comment.
Is this method being used? If not, can you remove it?
Contributor
Author
There was a problem hiding this comment.
You are right, it's not used. You don't think it could be useful to have a method to programmatically close all the "open" cells? Meaning cell being swiped.
Contributor
There was a problem hiding this comment.
I think it is fine to leave it.
breakingthebuild
assigned
elodieferrais and unassigned
ThePromoter and
breakingthebuild
breakingthebuild
added
revision needed
elodieferrais
added
need clarification
breakingthebuild
added
revision needed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now, when the single mode is one, we can only see one cell swiped at a time. When the user swipe a second cell, the first one close.