Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor event attendance #1188

Open
wants to merge 7 commits into
base: main
Choose a base branch
from
Open

Refactor event attendance #1188

wants to merge 7 commits into from

Conversation

jotjern
Copy link
Member

@jotjern jotjern commented Feb 20, 2025

Changes:

  • Rename extras to selections, choice to options to match html semantics
  • Merge AttendanceRepository and AttendancePoolRepository
  • Merge AttendanceService, AttendancePoolService
  • Merge WaitlistAttendee both as repository, service, and database table
  • Merge WebEventDetail and DashboardEventDetail

wip
Copy link

vercel bot commented Feb 20, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
dashboard ❌ Failed (Inspect) Feb 23, 2025 0:46am
web ✅ Ready (Inspect) Visit Preview Feb 23, 2025 0:46am

Copy link
Member

@junlarsen junlarsen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe options is a better name than questions?

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
@jotjern jotjern changed the title Refactor event attendance Refactor event attendance MONO-329 Mar 12, 2025
Copy link

linear bot commented Mar 12, 2025

@junlarsen junlarsen changed the title Refactor event attendance MONO-329 Refactor event attendance Mar 12, 2025
Copy link
Member

@junlarsen junlarsen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few small nits, also needs a rebase

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

rename to match naming convention

- Database credentials for the database in question. These are stored in Doppler
- Database credentials for the database in selection. These are stored in Doppler
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

revert

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants