Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

updated user status, removed isDeleted #359

Merged
merged 6 commits into from
Dec 6, 2024
Merged

updated user status, removed isDeleted #359

merged 6 commits into from
Dec 6, 2024

Conversation

bidi47
Copy link
Member

@bidi47 bidi47 commented Dec 2, 2024

No description provided.

@arhimede arhimede added this to the 6.0.0 milestone Dec 3, 2024
@arhimede arhimede added enhancement New feature or request 6.x labels Dec 3, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 3, 2024 •
edited
Loading

Qodana for PHP

It seems all right 👌

No new problems were found according to the checks applied

💡 Qodana analysis was run in the pull request mode: only the changed files were checked
☁️ View the detailed Qodana report

Detected 108 dependencies

Third-party software list

This page lists the third-party software dependencies used in project

Dependency Version Licenses
brick/math 0.12.1 MIT
brick/varexporter 0.5.0 MIT
defuse/php-encryption v2.4.0 MIT
doctrine/collections 2.2.2 MIT
doctrine/common 3.4.5 MIT
doctrine/data-fixtures 1.8.0 MIT
doctrine/dbal 4.2.1 MIT
doctrine/deprecations 1.1.3 MIT
doctrine/event-manager 2.0.1 MIT
doctrine/inflector 2.0.10 MIT
doctrine/instantiator 2.0.0 MIT
doctrine/lexer 3.0.1 MIT
doctrine/migrations 3.8.2 MIT
doctrine/orm 3.3.0 MIT
doctrine/persistence 3.4.0 MIT
dotkernel/dot-cache 4.1.0 MIT
dotkernel/dot-cli 3.6.1 MIT
dotkernel/dot-data-fixtures 1.2.3 MIT
dotkernel/dot-dependency-injection 1.1.0 MIT
dotkernel/dot-errorhandler 4.0.0 MIT
dotkernel/dot-event 3.4.2 MIT
dotkernel/dot-log 4.0.4 MIT
dotkernel/dot-mail 4.3.0 MIT
dotkernel/dot-response-header 3.4.0 MIT
fig/http-message-util 1.1.5 MIT
laminas/laminas-cli 1.11.0 BSD-3-Clause
laminas/laminas-component-installer 3.5.0 BSD-3-Clause
laminas/laminas-config-aggregator 1.17.0 BSD-3-Clause
laminas/laminas-diactoros 3.5.0 BSD-3-Clause
laminas/laminas-escaper 2.14.0 BSD-3-Clause
laminas/laminas-eventmanager 3.14.0 BSD-3-Clause
laminas/laminas-filter 2.39.0 BSD-3-Clause
laminas/laminas-httphandlerrunner 2.11.0 BSD-3-Clause
laminas/laminas-hydrator 4.16.0 BSD-3-Clause
laminas/laminas-inputfilter 2.31.0 BSD-3-Clause
laminas/laminas-loader 2.11.0 BSD-3-Clause
laminas/laminas-mail 2.25.1 BSD-3-Clause
laminas/laminas-mime 2.12.0 BSD-3-Clause
laminas/laminas-permissions-acl 2.17.0 BSD-3-Clause
laminas/laminas-permissions-rbac 3.7.0 BSD-3-Clause
laminas/laminas-servicemanager 3.23.0 BSD-3-Clause
laminas/laminas-stdlib 3.20.0 BSD-3-Clause
laminas/laminas-stratigility 3.13.0 BSD-3-Clause
laminas/laminas-validator 2.64.2 BSD-3-Clause
lcobucci/clock 3.3.1 MIT
lcobucci/jwt 5.4.2 BSD-3-Clause
league/event 2.2.0 MIT
league/oauth2-server 8.5.4 MIT
league/uri-interfaces 7.4.1 MIT
league/uri 7.4.1 MIT
mezzio/mezzio-authentication-oauth2 2.11.0 BSD-3-Clause
mezzio/mezzio-authentication 1.10.0 BSD-3-Clause
mezzio/mezzio-authorization-acl 1.11.0 BSD-3-Clause
mezzio/mezzio-authorization-rbac 1.8.0 BSD-3-Clause
mezzio/mezzio-authorization 1.10.0 BSD-3-Clause
mezzio/mezzio-cors 1.13.0 BSD-3-Clause
mezzio/mezzio-fastroute 3.12.0 BSD-3-Clause
mezzio/mezzio-hal 2.10.0 BSD-3-Clause
mezzio/mezzio-helpers 5.17.0 BSD-3-Clause
mezzio/mezzio-problem-details 1.15.0 BSD-3-Clause
mezzio/mezzio-router 3.18.0 BSD-3-Clause
mezzio/mezzio-template 2.11.0 BSD-3-Clause
mezzio/mezzio-twigrenderer 2.17.0 BSD-3-Clause
mezzio/mezzio 3.20.1 BSD-3-Clause
nikic/fast-route v1.3.0 BSD-3-Clause
nikic/php-parser v5.3.1 BSD-3-Clause
paragonie/random_compat v9.99.100 MIT
psr/cache 3.0.0 MIT
psr/clock 1.0.0 MIT
psr/container 1.1.2 MIT
psr/event-dispatcher 1.0.0 MIT
psr/http-client 1.0.3 MIT
psr/http-factory 1.1.0 MIT
psr/http-message 2.0 MIT
psr/http-server-handler 1.0.2 MIT
psr/http-server-middleware 1.0.2 MIT
psr/link 1.1.1 MIT
psr/log 3.0.2 MIT
ramsey/collection 2.0.0 MIT
ramsey/uuid-doctrine 2.1.0 MIT
ramsey/uuid 4.7.6 MIT
roave/psr-container-doctrine 5.5.0 BSD-2-Clause
spatie/array-to-xml 3.3.0 MIT
symfony/cache-contracts v3.5.1 MIT
symfony/cache v7.2.0 MIT
symfony/console v7.2.0 MIT
symfony/deprecation-contracts v3.5.1 MIT
symfony/event-dispatcher-contracts v3.5.1 MIT
symfony/event-dispatcher v7.2.0 MIT
symfony/filesystem v7.2.0 MIT
symfony/finder v7.2.0 MIT
symfony/polyfill-ctype v1.31.0 MIT
symfony/polyfill-intl-grapheme v1.31.0 MIT
symfony/polyfill-intl-idn v1.31.0 MIT
symfony/polyfill-intl-normalizer v1.31.0 MIT
symfony/polyfill-mbstring v1.31.0 MIT
symfony/polyfill-php80 v1.31.0 MIT
symfony/polyfill-php81 v1.31.0 MIT
symfony/service-contracts v3.5.1 MIT
symfony/stopwatch v7.2.0 MIT
symfony/string v7.2.0 MIT
symfony/var-exporter v7.2.0 MIT
symfony/yaml v7.2.0 MIT
twig/twig v3.16.0 BSD-3-Clause
webimpress/safe-writer 2.2.0 BSD-2-Clause
webmozart/assert 1.11.0 MIT
willdurand/negotiation 3.1.0 MIT
zircote/swagger-php 4.11.1 Apache-2.0
Contact Qodana team

Contact us at [email protected]

@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 3, 2024

Qodana for PHP

It seems all right 👌

No new problems were found according to the checks applied

💡 Qodana analysis was run in the pull request mode: only the changed files were checked
☁️ View the detailed Qodana report

Detected 108 dependencies

Third-party software list

This page lists the third-party software dependencies used in project

Dependency Version Licenses
brick/math 0.12.1 MIT
brick/varexporter 0.5.0 MIT
defuse/php-encryption v2.4.0 MIT
doctrine/collections 2.2.2 MIT
doctrine/common 3.4.5 MIT
doctrine/data-fixtures 1.8.0 MIT
doctrine/dbal 4.2.1 MIT
doctrine/deprecations 1.1.3 MIT
doctrine/event-manager 2.0.1 MIT
doctrine/inflector 2.0.10 MIT
doctrine/instantiator 2.0.0 MIT
doctrine/lexer 3.0.1 MIT
doctrine/migrations 3.8.2 MIT
doctrine/orm 3.3.0 MIT
doctrine/persistence 3.4.0 MIT
dotkernel/dot-cache 4.1.0 MIT
dotkernel/dot-cli 3.6.1 MIT
dotkernel/dot-data-fixtures 1.2.3 MIT
dotkernel/dot-dependency-injection 1.1.0 MIT
dotkernel/dot-errorhandler 4.0.0 MIT
dotkernel/dot-event 3.4.2 MIT
dotkernel/dot-log 4.0.4 MIT
dotkernel/dot-mail 4.3.0 MIT
dotkernel/dot-response-header 3.4.0 MIT
fig/http-message-util 1.1.5 MIT
laminas/laminas-cli 1.11.0 BSD-3-Clause
laminas/laminas-component-installer 3.5.0 BSD-3-Clause
laminas/laminas-config-aggregator 1.17.0 BSD-3-Clause
laminas/laminas-diactoros 3.5.0 BSD-3-Clause
laminas/laminas-escaper 2.14.0 BSD-3-Clause
laminas/laminas-eventmanager 3.14.0 BSD-3-Clause
laminas/laminas-filter 2.39.0 BSD-3-Clause
laminas/laminas-httphandlerrunner 2.11.0 BSD-3-Clause
laminas/laminas-hydrator 4.16.0 BSD-3-Clause
laminas/laminas-inputfilter 2.31.0 BSD-3-Clause
laminas/laminas-loader 2.11.0 BSD-3-Clause
laminas/laminas-mail 2.25.1 BSD-3-Clause
laminas/laminas-mime 2.12.0 BSD-3-Clause
laminas/laminas-permissions-acl 2.17.0 BSD-3-Clause
laminas/laminas-permissions-rbac 3.7.0 BSD-3-Clause
laminas/laminas-servicemanager 3.23.0 BSD-3-Clause
laminas/laminas-stdlib 3.20.0 BSD-3-Clause
laminas/laminas-stratigility 3.13.0 BSD-3-Clause
laminas/laminas-validator 2.64.2 BSD-3-Clause
lcobucci/clock 3.3.1 MIT
lcobucci/jwt 5.4.2 BSD-3-Clause
league/event 2.2.0 MIT
league/oauth2-server 8.5.4 MIT
league/uri-interfaces 7.4.1 MIT
league/uri 7.4.1 MIT
mezzio/mezzio-authentication-oauth2 2.11.0 BSD-3-Clause
mezzio/mezzio-authentication 1.10.0 BSD-3-Clause
mezzio/mezzio-authorization-acl 1.11.0 BSD-3-Clause
mezzio/mezzio-authorization-rbac 1.8.0 BSD-3-Clause
mezzio/mezzio-authorization 1.10.0 BSD-3-Clause
mezzio/mezzio-cors 1.13.0 BSD-3-Clause
mezzio/mezzio-fastroute 3.12.0 BSD-3-Clause
mezzio/mezzio-hal 2.10.0 BSD-3-Clause
mezzio/mezzio-helpers 5.17.0 BSD-3-Clause
mezzio/mezzio-problem-details 1.15.0 BSD-3-Clause
mezzio/mezzio-router 3.18.0 BSD-3-Clause
mezzio/mezzio-template 2.11.0 BSD-3-Clause
mezzio/mezzio-twigrenderer 2.17.0 BSD-3-Clause
mezzio/mezzio 3.20.1 BSD-3-Clause
nikic/fast-route v1.3.0 BSD-3-Clause
nikic/php-parser v5.3.1 BSD-3-Clause
paragonie/random_compat v9.99.100 MIT
psr/cache 3.0.0 MIT
psr/clock 1.0.0 MIT
psr/container 1.1.2 MIT
psr/event-dispatcher 1.0.0 MIT
psr/http-client 1.0.3 MIT
psr/http-factory 1.1.0 MIT
psr/http-message 2.0 MIT
psr/http-server-handler 1.0.2 MIT
psr/http-server-middleware 1.0.2 MIT
psr/link 1.1.1 MIT
psr/log 3.0.2 MIT
ramsey/collection 2.0.0 MIT
ramsey/uuid-doctrine 2.1.0 MIT
ramsey/uuid 4.7.6 MIT
roave/psr-container-doctrine 5.5.0 BSD-2-Clause
spatie/array-to-xml 3.3.0 MIT
symfony/cache-contracts v3.5.1 MIT
symfony/cache v7.2.0 MIT
symfony/console v7.2.0 MIT
symfony/deprecation-contracts v3.5.1 MIT
symfony/event-dispatcher-contracts v3.5.1 MIT
symfony/event-dispatcher v7.2.0 MIT
symfony/filesystem v7.2.0 MIT
symfony/finder v7.2.0 MIT
symfony/polyfill-ctype v1.31.0 MIT
symfony/polyfill-intl-grapheme v1.31.0 MIT
symfony/polyfill-intl-idn v1.31.0 MIT
symfony/polyfill-intl-normalizer v1.31.0 MIT
symfony/polyfill-mbstring v1.31.0 MIT
symfony/polyfill-php80 v1.31.0 MIT
symfony/polyfill-php81 v1.31.0 MIT
symfony/service-contracts v3.5.1 MIT
symfony/stopwatch v7.2.0 MIT
symfony/string v7.2.0 MIT
symfony/var-exporter v7.2.0 MIT
symfony/yaml v7.2.0 MIT
twig/twig v3.16.0 BSD-3-Clause
webimpress/safe-writer 2.2.0 BSD-2-Clause
webmozart/assert 1.11.0 MIT
willdurand/negotiation 3.1.0 MIT
zircote/swagger-php 4.11.1 Apache-2.0
Contact Qodana team

Contact us at [email protected]

@bidi47 bidi47 requested a review from alexmerlin December 3, 2024 11:52
alexmerlin
alexmerlin requested changes Dec 3, 2024
View reviewed changes
@alexmerlin
Copy link
Member

@bidi47 Also, let's create an Dotkernel API issue for this based on dotkernel/frontend#523 then link that issue with this PR.

bidi47 added 2 commits December 3, 2024 17:25
@bidi47
resolved comments
4e1ff1f 
Signed-off-by: bidi <[email protected]>
@bidi47
fixed phpcs
c95fb1a 
Signed-off-by: bidi <[email protected]>
@bidi47 bidi47 linked an issue Dec 3, 2024 that may be closed by this pull request
Update user status handling #362
Closed
@alexmerlin
Copy link
Member

@arhimede
When an (super)admin fetches a list of users, should the response contain deleted users as well?
Same question for when an admin tries to fetch a deleted user.

With the previous approach (using isDeleted):

  • list users response did by default include isDeleted=1 users as well (could be filtered, though)
  • view user by uuid response did return isDeleted=1 users as well (instead of throwing a Not found response)

@arhimede
Copy link
Member

arhimede commented Dec 4, 2024

@arhimede When an (super)admin fetches a list of users, should the response contain deleted users as well? Same question for when an admin tries to fetch a deleted user.

With the previous approach (using isDeleted):

* `list users` response **did** by default include `isDeleted=1` users as well (could be filtered, though)

* `view user by uuid` response did return `isDeleted=1` users as well (instead of throwing a `Not found` response)

If a record is deleted in database, even Soft deleted, should not appear in any search results, in any endpoint

@bidi47 bidi47 requested a review from alexmerlin December 4, 2024 14:53
alexmerlin
alexmerlin requested changes Dec 4, 2024
View reviewed changes
@arhimede arhimede added 5.x and removed 6.x labels Dec 5, 2024
@arhimede arhimede modified the milestones: 6.0.0, 5.3.0 Dec 5, 2024
@arhimede arhimede requested a review from alexmerlin December 6, 2024 10:59
@arhimede arhimede merged commit 113bf55 into 5.0 Dec 6, 2024
22 checks passed
@alexmerlin alexmerlin deleted the issue-523 branch December 6, 2024 11:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexmerlin alexmerlin alexmerlin approved these changes

@arhimede arhimede arhimede approved these changes

Assignees
No one assigned
Labels
5.x enhancement New feature or request
Projects
None yet
Milestone
5.3.0
Development

Successfully merging this pull request may close these issues.

Update user status handling
3 participants
@bidi47 @alexmerlin @arhimede