Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue #313: Remove config dependency from handlers. #315

Merged
merged 1 commit into from
Sep 13, 2024
Merged

Conversation

alexmerlin
Copy link
Member

This implementation removes the dependency of config from all handlers.
It also introduces new handlers for collection related endpoints.

@cPintiuta @MarioRadu let me know your thoughts, if this implementation solves the issue described in #313 or I should look into other solutions.

@alexmerlin alexmerlin added enhancement New feature or request 5.x labels Sep 10, 2024
@alexmerlin alexmerlin self-assigned this Sep 10, 2024
Copy link

Qodana for PHP

It seems all right 👌

No new problems were found according to the checks applied

💡 Qodana analysis was run in the pull request mode: only the changed files were checked
☁️ View the detailed Qodana report

Detected 113 dependencies

Third-party software list

This page lists the third-party software dependencies used in project

Dependency Version Licenses
brick/math 0.12.1 MIT
brick/varexporter 0.4.0 MIT
defuse/php-encryption v2.4.0 MIT
doctrine/collections 2.2.2 MIT
doctrine/common 3.4.4 MIT
doctrine/data-fixtures 1.7.0 MIT
doctrine/dbal 4.1.1 MIT
doctrine/deprecations 1.1.3 MIT
doctrine/event-manager 2.0.1 MIT
doctrine/inflector 2.0.10 MIT
doctrine/instantiator 2.0.0 MIT
doctrine/lexer 3.0.1 MIT
doctrine/migrations 3.8.1 MIT
doctrine/orm 3.2.2 MIT
doctrine/persistence 3.3.3 MIT
dotkernel/dot-cache 4.1.0 MIT
dotkernel/dot-cli 3.6.1 MIT
dotkernel/dot-data-fixtures 1.2.3 MIT
dotkernel/dot-dependency-injection 1.0.0 MIT
dotkernel/dot-errorhandler 4.0.0 MIT
dotkernel/dot-event 3.4.2 MIT
dotkernel/dot-log 4.0.2 MIT
dotkernel/dot-mail 4.2.2 MIT
dotkernel/dot-response-header 3.3.1 MIT
fig/http-message-util 1.1.5 MIT
laminas/laminas-cli 1.10.0 BSD-3-Clause
laminas/laminas-component-installer 3.4.0 BSD-3-Clause
laminas/laminas-config-aggregator 1.15.0 BSD-3-Clause
laminas/laminas-config 3.9.0 BSD-3-Clause
laminas/laminas-diactoros 3.3.1 BSD-3-Clause
laminas/laminas-escaper 2.13.0 BSD-3-Clause
laminas/laminas-eventmanager 3.13.1 BSD-3-Clause
laminas/laminas-filter 2.37.0 BSD-3-Clause
laminas/laminas-http 2.19.0 BSD-3-Clause
laminas/laminas-httphandlerrunner 2.10.0 BSD-3-Clause
laminas/laminas-hydrator 4.15.0 BSD-3-Clause
laminas/laminas-inputfilter 2.30.1 BSD-3-Clause
laminas/laminas-loader 2.10.0 BSD-3-Clause
laminas/laminas-mail 2.25.1 BSD-3-Clause
laminas/laminas-mime 2.12.0 BSD-3-Clause
laminas/laminas-paginator 2.18.1 BSD-3-Clause
laminas/laminas-permissions-acl 2.16.0 BSD-3-Clause
laminas/laminas-permissions-rbac 3.6.0 BSD-3-Clause
laminas/laminas-servicemanager 3.22.1 BSD-3-Clause
laminas/laminas-stdlib 3.19.0 BSD-3-Clause
laminas/laminas-stratigility 3.12.0 BSD-3-Clause
laminas/laminas-text 2.11.0 BSD-3-Clause
laminas/laminas-uri 2.12.0 BSD-3-Clause
laminas/laminas-validator 2.64.1 BSD-3-Clause
lcobucci/clock 3.2.0 MIT
lcobucci/jwt 5.3.0 BSD-3-Clause
league/event 2.2.0 MIT
league/oauth2-server 8.5.4 MIT
league/uri-interfaces 7.4.1 MIT
league/uri 7.4.1 MIT
mezzio/mezzio-authentication-oauth2 2.10.1 BSD-3-Clause
mezzio/mezzio-authentication 1.9.0 BSD-3-Clause
mezzio/mezzio-authorization-acl 1.10.0 BSD-3-Clause
mezzio/mezzio-authorization-rbac 1.7.0 BSD-3-Clause
mezzio/mezzio-authorization 1.9.0 BSD-3-Clause
mezzio/mezzio-cors 1.12.1 BSD-3-Clause
mezzio/mezzio-fastroute 3.11.0 BSD-3-Clause
mezzio/mezzio-hal 2.9.0 BSD-3-Clause
mezzio/mezzio-helpers 5.16.0 BSD-3-Clause
mezzio/mezzio-problem-details 1.14.0 BSD-3-Clause
mezzio/mezzio-router 3.17.0 BSD-3-Clause
mezzio/mezzio-template 2.10.0 BSD-3-Clause
mezzio/mezzio-twigrenderer 2.16.0 BSD-3-Clause
mezzio/mezzio 3.19.1 BSD-3-Clause
nikic/fast-route v1.3.0 BSD-3-Clause
nikic/php-parser v4.19.1 BSD-3-Clause
paragonie/random_compat v9.99.100 MIT
psr/cache 3.0.0 MIT
psr/clock 1.0.0 MIT
psr/container 1.1.2 MIT
psr/event-dispatcher 1.0.0 MIT
psr/http-client 1.0.3 MIT
psr/http-factory 1.1.0 MIT
psr/http-message 1.1 MIT
psr/http-server-handler 1.0.2 MIT
psr/http-server-middleware 1.0.2 MIT
psr/link 1.1.1 MIT
psr/log 3.0.1 MIT
ramsey/collection 2.0.0 MIT
ramsey/uuid-doctrine 2.1.0 MIT
ramsey/uuid 4.7.6 MIT
roave/psr-container-doctrine 5.2.2 BSD-2-Clause
spatie/array-to-xml 3.3.0 MIT
symfony/cache-contracts v3.5.0 MIT
symfony/cache v7.1.4 MIT
symfony/console v7.1.4 MIT
symfony/deprecation-contracts v3.5.0 MIT
symfony/event-dispatcher-contracts v3.5.0 MIT
symfony/event-dispatcher v7.1.1 MIT
symfony/filesystem v7.1.2 MIT
symfony/finder v7.1.4 MIT
symfony/polyfill-ctype v1.31.0 MIT
symfony/polyfill-intl-grapheme v1.31.0 MIT
symfony/polyfill-intl-idn v1.31.0 MIT
symfony/polyfill-intl-normalizer v1.31.0 MIT
symfony/polyfill-mbstring v1.31.0 MIT
symfony/polyfill-php80 v1.31.0 MIT
symfony/polyfill-php81 v1.31.0 MIT
symfony/service-contracts v3.5.0 MIT
symfony/stopwatch v7.1.1 MIT
symfony/string v7.1.4 MIT
symfony/var-exporter v7.1.2 MIT
symfony/yaml v7.1.4 MIT
twig/twig v3.14.0 BSD-3-Clause
webimpress/safe-writer 2.2.0 BSD-2-Clause
webmozart/assert 1.11.0 MIT
willdurand/negotiation 3.1.0 MIT
zircote/swagger-php 4.10.6 Apache-2.0
Contact Qodana team

Contact us at [email protected]

@MarioRadu
Copy link
Member

So now all routes that return a collection will have their own handler ? @alexmerlin

@alexmerlin
Copy link
Member Author

So now all routes that return a collection will have their own handler ? @alexmerlin

Yes, all collection routes with their own handler that's sole purpose is to have a get method that returns the requested collection.

This PR is not a final solution (unless accepted), but to me it looked to be the simplest and most straightforward one.
If there are opinions against it, we can look for other solutions as well.

Copy link
Member

@MarioRadu MarioRadu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good from my side.

@arhimede arhimede linked an issue Sep 13, 2024 that may be closed by this pull request
@arhimede arhimede merged commit 33c3052 into 5.0 Sep 13, 2024
22 checks passed
@alexmerlin alexmerlin deleted the issue-313 branch September 13, 2024 10:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
5.x enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants