implemented enumType class for admin status column

[kakapiciu]

#212 2.2

[codecov]

Codecov Report

Attention: 9 lines in your changes are missing coverage. Please review.

Comparison is base (2eb6e2d) 65.22% compared to head (40524b9) 64.88%.
Report is 27 commits behind head on 4.0.

Files	Patch %	Lines
src/Admin/src/Entity/EnumAdminStatus.php	0.00%	9 Missing ⚠️

Additional details and impacted files

@@             Coverage Diff              @@
##                4.0     #216      +/-   ##
============================================
- Coverage     65.22%   64.88%   -0.34%     
- Complexity      363      367       +4     
============================================
  Files            49       50       +1     
  Lines          1734     1743       +9     
============================================
  Hits           1131     1131              
- Misses          603      612       +9     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[alexmerlin]

This seems to be a mixture of the two solutions (2.1 and 2.2) that I recommended.
The point of 2.2 is to have a single EnumType class that can be reused across all entities.
My recommendations:

• create a new directory inside src/App/src, call it Doctrine or Types
• refactor src/Admin/src/Entity/EnumAdminStatus.php by moving it to that new directory and calling it EnumType
• register EnumType inside config/autoload/doctrine.global.php as before
• adapt Admin entity by setting the status property's type to EnumType::NAME

Note:
Once you run the migration and the fixture, executing the diff command will throw an error, complaining that in EnumType::getSQLDeclaration the key values does not exist (neither would default, but that's a coincidence that it exists in both the type definition and the database table). This happens because executing the diff command will compare the already existing status column with the definition found in the entity. It is the definition coming from the database that does not have the values key.
You need to dig further in order to find out how to fix this issue.

[arhimede]

Let's keep this open until we decide what to do with it