Bugfix: enums from external fragments were not generated along with operations by ikusakov2 · Pull Request #10565 · dotansimha/graphql-code-generator

ikusakov2 · 2026-01-07T20:25:41Z

Description

This PR includes 2 fixes:

enums from external fragment were not copied to the generated file along with operations.
extractAllFieldsToTypesCompact config option in certain conditions generate duplicate names

Additionally, an integration test is added that mimics the Apollo-tooling setup:
dev-test-apollo-tooling

Testing

Unit tests

changeset-bot · 2026-01-07T20:32:27Z

🦋 Changeset detected

Latest commit: 180a80a

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 9 packages

Name	Type
@graphql-codegen/typescript-operations	Minor
@graphql-codegen/visitor-plugin-common	Minor
@graphql-codegen/typescript-document-nodes	Patch
@graphql-codegen/gql-tag-operations	Patch
@graphql-codegen/typescript-resolvers	Patch
@graphql-codegen/typed-document-node	Patch
@graphql-codegen/typescript	Patch
@graphql-codegen/graphql-modules-preset	Patch
@graphql-codegen/client-preset	Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

…config-extractAllFieldsToTypesCompact

eddeee888 · 2026-01-08T12:24:44Z

packages/plugins/typescript/operations/src/visitor.ts

+    const documentWithExternalFragments: DocumentNode = {
+      ...documentNode,
+      definitions: [...documentNode.definitions, ...(config.externalFragments || []).map(f => f.node)],
+    };


I wonder if the functionality in the above statement used to create allFragments could be used for our fragments here somehow? 🤔
It seems to do a similar function of collecting fragments, either from documents or from config.

Good call!
Check the new code - I combined it with allFragments.

eddeee888 · 2026-01-08T12:28:45Z

dev-test-alpha/.gitignore

@@ -0,0 +1,2 @@
+**/__generated__/**


I feel we should unignore the generation 🙂
This could be a good test that can be kept as snapshot test, and an advanced use case of codegen

OK, generated files added!

ikusakov2 · 2026-01-08T20:08:20Z

dev-test-alpha/cli/index.ts

@@ -0,0 +1,106 @@
+#!/usr/bin/env ts-node


I created the dev-test-alpha just as a temporary package to demonstrate our company issues.
Do you think it would be worth keeping it?
Then:

I'll need to add some tests which would get invoked when global tests are running.

We need to come up with some better name than dev-test-alpha

Yes, I think so! I find this test is very valuable, as it can be used to catch unexpected bugs, at least in the initial stage after rolling out.

I feel we might be able to simplify a few things in the setup. And worst case, if its usefulness is overshadowed by maintenance, we can decide to drop it (or further simplify) later 🙂

OK, I renamed dev-test-alpha to dev-test-apollo-tooling - to give a more descriptive name to what this integration test it about. I also added another (hopefully last) fix - so you can run yarn install && yarn build from the root directory: graphql-code-generator and - it should work.

ikusakov2 · 2026-01-08T20:14:12Z

dev-test-alpha/src/__generated__/Component.ts

+// @generated
+// This file was automatically generated and should not be edited.
+
+import type * as Types from '../../graphql-code-generator/dev-test-alpha/src/__generated__/globalTypes';


I think we already worked on removing this line in typescript-operations plugin.
But it probably comes from near-operation-file preset.
Shall we ignore it until we do the next version of near-operation-file?

I did a research and - yes, it comes from near-operation-file.

ikusakov2 · 2026-01-08T20:14:49Z

dev-test-alpha/src/__generated__/Component.ts

+
+type Exact<T extends { [key: string]: unknown }> = { [K in keyof T]: T[K] };
+export type Incremental<T> = T | { [P in keyof T]?: P extends ' $fragmentName' | '__typename' ? T[P] : never };
+export enum UserManagerRoleType {


With the recent fix - it adds the enum in the correct file.

…config-extractAllFieldsToTypesCompact

…esCompact

…config-extractAllFieldsToTypesCompact

eddeee888 · 2026-01-19T11:11:39Z

yarn.lock

👆 The previous commit had package issues because there were lots of changes (+4k -2k LOC changes) in yarn.lock, which I think caused some package versions to be conflicting.

I've fixed this issue in this commit

git checkout b55828d4ea802db1476fb7eaada41592b9c80985 -- yarn.lock // get working yarn.lock of a stable commit yarn // re-install packages whilst checking that minimal line changes happened and tests can run

…TypesCompact

eddeee888

Nice one!

…perations (#10565) * integration test * cleanups * cleanups2 * fixed a bug with external fragments * cleanup * keep generated files, refactored visitorwq * cleanup * changeset * adding missing dependency * delete temporary files * cleanup * cleanups * Adding back the integration tests + fix them * merged + fixes * cleanup * cleanup * patching near-operation-file preset * cleanup * adding duplicates case to integration tests * Fixing bug with duplicates generated when using extractAllFieldsToTypesCompact * cleanup * prevent running prettier on generated code * cleanups * cleanup * adding unit tests * update changeset * cleanups * try resolving graphql 16 error * remove unused deps * remove unused deps * cleanups * Revert and apply minimal yarn.lock changes --------- Co-authored-by: ikusakov <ikusakov@gxnfgqk426.y.yelp> Co-authored-by: Igor Kusakov <igor@kusakov.com> Co-authored-by: Eddy Nguyen <github@eddeee888.me> Co-authored-by: Eddy Nguyen <ch@eddeee888.me>

…perations (dotansimha#10565) * integration test * cleanups * cleanups2 * fixed a bug with external fragments * cleanup * keep generated files, refactored visitorwq * cleanup * changeset * adding missing dependency * delete temporary files * cleanup * cleanups * Adding back the integration tests + fix them * merged + fixes * cleanup * cleanup * patching near-operation-file preset * cleanup * adding duplicates case to integration tests * Fixing bug with duplicates generated when using extractAllFieldsToTypesCompact * cleanup * prevent running prettier on generated code * cleanups * cleanup * adding unit tests * update changeset * cleanups * try resolving graphql 16 error * remove unused deps * remove unused deps * cleanups * Revert and apply minimal yarn.lock changes --------- Co-authored-by: ikusakov <ikusakov@gxnfgqk426.y.yelp> Co-authored-by: Igor Kusakov <igor@kusakov.com> Co-authored-by: Eddy Nguyen <github@eddeee888.me> Co-authored-by: Eddy Nguyen <ch@eddeee888.me>

…perations (#10565) * integration test * cleanups * cleanups2 * fixed a bug with external fragments * cleanup * keep generated files, refactored visitorwq * cleanup * changeset * adding missing dependency * delete temporary files * cleanup * cleanups * Adding back the integration tests + fix them * merged + fixes * cleanup * cleanup * patching near-operation-file preset * cleanup * adding duplicates case to integration tests * Fixing bug with duplicates generated when using extractAllFieldsToTypesCompact * cleanup * prevent running prettier on generated code * cleanups * cleanup * adding unit tests * update changeset * cleanups * try resolving graphql 16 error * remove unused deps * remove unused deps * cleanups * Revert and apply minimal yarn.lock changes --------- Co-authored-by: ikusakov <ikusakov@gxnfgqk426.y.yelp> Co-authored-by: Igor Kusakov <igor@kusakov.com> Co-authored-by: Eddy Nguyen <github@eddeee888.me> Co-authored-by: Eddy Nguyen <ch@eddeee888.me>

integration test

6616585

ikusakov2 changed the title ~~An intergration test showing errors with recent alpha version~~ An integration test showing errors with recent alpha version Jan 7, 2026

ikusakov2 changed the base branch from master to master-next January 7, 2026 20:27

cleanups

7e204c1

ikusakov added 3 commits January 7, 2026 15:33

cleanups2

2fc4571

Merge remote-tracking branch 'upstream/master-next' into feature/add-…

056dbd0

…config-extractAllFieldsToTypesCompact

fixed a bug with external fragments

ba85977

ikusakov2 marked this pull request as ready for review January 7, 2026 22:03

cleanup

6fd5428

eddeee888 reviewed Jan 8, 2026

View reviewed changes

keep generated files, refactored visitorwq

790b876

ikusakov2 commented Jan 8, 2026

View reviewed changes

cleanup

e73b9ba

ikusakov2 closed this Jan 8, 2026

ikusakov2 deleted the feature/add-config-extractAllFieldsToTypesCompact branch January 8, 2026 23:00

ikusakov2 restored the feature/add-config-extractAllFieldsToTypesCompact branch January 8, 2026 23:02

ikusakov2 reopened this Jan 8, 2026

ikusakov added 3 commits January 8, 2026 19:52

changeset

1f54f42

adding missing dependency

900aa10

delete temporary files

10a2774

ikusakov2 changed the title ~~An integration test showing errors with recent alpha version~~ Fixing an issue with including enums from external fragments Jan 12, 2026

ikusakov added 2 commits January 12, 2026 17:01

cleanup

10d3b85

cleanups

9b3dbf8

ikusakov2 changed the title ~~Fixing an issue with including enums from external fragments~~ Bugfix: enums from external fragments were not generated along with operations Jan 12, 2026

ikusakov added 2 commits January 12, 2026 17:27

Adding back the integration tests + fix them

64b7834

Merge remote-tracking branch 'upstream/master-next' into feature/add-…

17c9614

…config-extractAllFieldsToTypesCompact

eddeee888 mentioned this pull request Jan 15, 2026

[typescript-operations/client-preset] Next major version #10496

Draft

10 tasks

ikusakov added 14 commits January 15, 2026 16:01

adding duplicates case to integration tests

4d86e60

Fixing bug with duplicates generated when using extractAllFieldsToTyp…

85fd378

…esCompact

cleanup

d7e75e3

Merge remote-tracking branch 'upstream/master-next' into feature/add-…

28e61b0

…config-extractAllFieldsToTypesCompact

prevent running prettier on generated code

b474a3f

cleanups

5f4666c

cleanup

da8f02a

adding unit tests

899fd58

update changeset

4789809

cleanups

15b4278

try resolving graphql 16 error

24f7aec

remove unused deps

ed99011

remove unused deps

2740719

cleanups

65d158a

eddeee888 mentioned this pull request Jan 19, 2026

Test revert yarn lock #10576

Closed

Revert and apply minimal yarn.lock changes

eec25ef

eddeee888 reviewed Jan 19, 2026

View reviewed changes

Merge branch 'master-next' into feature/add-config-extractAllFieldsTo…

180a80a

…TypesCompact

eddeee888 approved these changes Jan 19, 2026

View reviewed changes

eddeee888 merged commit b51daba into dotansimha:master-next Jan 19, 2026
19 checks passed

Conversation

ikusakov2 commented Jan 7, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Testing

Uh oh!

changeset-bot bot commented Jan 7, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🦋 Changeset detected

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

eddeee888 Jan 11, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

ikusakov2 Jan 8, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

eddeee888 Jan 19, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

eddeee888 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

ikusakov2 commented Jan 7, 2026 •

edited

Loading

changeset-bot bot commented Jan 7, 2026 •

edited

Loading

eddeee888 Jan 11, 2026 •

edited

Loading

ikusakov2 Jan 8, 2026 •

edited

Loading

eddeee888 Jan 19, 2026 •

edited

Loading