[typescript-operations] No optional Result fields, unless deferred or conditional#10548
Merged
eddeee888 merged 5 commits intomaster-nextfrom Dec 17, 2025
Merged
[typescript-operations] No optional Result fields, unless deferred or conditional#10548eddeee888 merged 5 commits intomaster-nextfrom
eddeee888 merged 5 commits intomaster-nextfrom
Conversation
🦋 Changeset detectedLatest commit: 0e883fc The changes in this PR will be included in the next version bump. This PR includes changesets to release 11 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
10 tasks
eddeee888
added a commit
that referenced
this pull request
Jan 6, 2026
… conditional (#10548) * Fix types issues and put comments * Handle avoidOptionals * Update integration tests * Add FIXME to pass test for now * Add changeset
eddeee888
added a commit
that referenced
this pull request
Jan 20, 2026
… conditional (#10548) * Fix types issues and put comments * Handle avoidOptionals * Update integration tests * Add FIXME to pass test for now * Add changeset
eddeee888
added a commit
that referenced
this pull request
Feb 25, 2026
… conditional (#10548) * Fix types issues and put comments * Handle avoidOptionals * Update integration tests * Add FIXME to pass test for now * Add changeset
eddeee888
added a commit
that referenced
this pull request
Mar 3, 2026
… conditional (#10548) * Fix types issues and put comments * Handle avoidOptionals * Update integration tests * Add FIXME to pass test for now * Add changeset
ikusakov2
pushed a commit
to ikusakov2/graphql-code-generator
that referenced
this pull request
Mar 4, 2026
… conditional (dotansimha#10548) * Fix types issues and put comments * Handle avoidOptionals * Update integration tests * Add FIXME to pass test for now * Add changeset
eddeee888
added a commit
that referenced
this pull request
Mar 8, 2026
… conditional (#10548) * Fix types issues and put comments * Handle avoidOptionals * Update integration tests * Add FIXME to pass test for now * Add changeset
eddeee888
added a commit
that referenced
this pull request
Mar 8, 2026
… conditional (#10548) * Fix types issues and put comments * Handle avoidOptionals * Update integration tests * Add FIXME to pass test for now * Add changeset
eddeee888
added a commit
that referenced
this pull request
Mar 8, 2026
… conditional (#10548) * Fix types issues and put comments * Handle avoidOptionals * Update integration tests * Add FIXME to pass test for now * Add changeset
eddeee888
added a commit
that referenced
this pull request
Mar 12, 2026
… conditional (#10548) * Fix types issues and put comments * Handle avoidOptionals * Update integration tests * Add FIXME to pass test for now * Add changeset
eddeee888
added a commit
that referenced
this pull request
Mar 19, 2026
… conditional (#10548) * Fix types issues and put comments * Handle avoidOptionals * Update integration tests * Add FIXME to pass test for now * Add changeset
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fix Result fields being optional. In normal use cases, a requested field cannot be optional, just null.
There are some cases where a field can be optional:
@skipor@include)This PR fixes the issue by removing all related
avoidOptionalsfor standard Result fields scenarios.This makes it tighter and avoids the issue where users arbitrarily configure the result, which can lead to foot-gun situations
Related #10496
Type of change
How Has This Been Tested?