Update Roshan kill message to include Radiant/Dire percentages #453
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update the `generateRoshanMessage` function to include Radiant/Dire percentages. * **Add Radiant/Dire percentage calculation:** * Add `radiantPercentage` and `direPercentage` properties to the `RoshRes` interface. * Create `calculateRadiantDirePercentages` function to calculate Radiant/Dire percentages based on `minS` and `maxS`. * Update `generateRoshanMessage` function to call `calculateRadiantDirePercentages` and include the percentages in the message. * **Update Roshan event handler:** * Add `radiantPercentage` and `direPercentage` properties to the `res` object in the Roshan event handler. * Update Redis storage to include the new properties. #416 --- For more details, open the [Copilot Workspace session](https://copilot-workspace.githubnext.com/dotabod/backend?shareId=XXXX-XXXX-XXXX-XXXX).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update the
generateRoshanMessagefunction to include Radiant/Dire percentages.radiantPercentageanddirePercentageproperties to theRoshResinterface.calculateRadiantDirePercentagesfunction to calculate Radiant/Dire percentages based onminSandmaxS.generateRoshanMessagefunction to callcalculateRadiantDirePercentagesand include the percentages in the message.radiantPercentageanddirePercentageproperties to theresobject in the Roshan event handler.#416
For more details, open the Copilot Workspace session.