chore(block-editor): Fix add links #29880
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…en-below-on-the-editor
nicobytes
changed the title
nicobytes
changed the title
…en-below-on-the-editor
…en-below-on-the-editor
…en-below-on-the-editor
oidacra
approved these changes
Sep 6, 2024
hmoreras
requested changes
Sep 10, 2024
| @@ -187,6 +190,8 @@ describe('DotUploadAssetComponent', () => { | |||
| ); | |||
| const emitSpy = jest.spyOn(component.uploadedFile, 'emit'); | |||
|
|
|||
| console.log(de.nativeElement.innerHTML); | |||
…en-below-on-the-editor
…en-below-on-the-editor
…en-below-on-the-editor
…-below-on-the-editor
…-below-on-the-editor
…he-editor' of github.com:dotCMS/core into 29672-block-editor-add-link-doesnt-show-when-below-on-the-editor
…-below-on-the-editor
|
…-below-on-the-editor
…-below-on-the-editor
…-below-on-the-editor
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Parent Issue
#29672
Proposed Changes
This pull request includes several changes to improve the testing framework and refactor component specifications in the
core-weblibrary. The most important changes include refactoring test setups to useSpectator, updating component templates, and cleaning up unused code.Refactoring to use Spectator:
core-web/libs/block-editor/src/lib/extensions/ai-content-prompt/ai-content-prompt.component.spec.ts: Refactored to useSpectatorfor better test readability and maintainability.core-web/libs/block-editor/src/lib/extensions/asset-form/asset-form.component.spec.ts: Refactored to useSpectatorfor improved test structure.core-web/libs/block-editor/src/lib/extensions/asset-uploader/components/upload-placeholder/upload-placeholder.component.spec.ts: Refactored to useSpectatorfor better test readability.core-web/libs/block-editor/src/lib/shared/components/suggestions/suggestions.component.spec.ts: Refactored to useSpectatorand added mock providers for dependencies.core-web/libs/block-editor/src/lib/shared/services/suggestions/suggestions.service.spec.ts: Refactored to useSpectatorHttpfor HTTP service tests.Component template updates:
core-web/libs/block-editor/src/lib/components/dot-block-editor/dot-block-editor.component.spec.ts: Simplified the template by using self-closing tags.core-web/libs/block-editor/src/lib/extensions/asset-form/components/dot-upload-asset/dot-upload-asset.component.html: Updated template to use@ifand@elsedirectives for better readability. [1] [2]core-web/libs/block-editor/src/lib/extensions/bubble-form/bubble-form.component.html: Corrected the loop tracking mechanism in the template.Cleanup and removal of unused code:
core-web/libs/block-editor/src/lib/extensions/bubble-link-form/bubble-link-form.component.spec.ts: Removed the unused test file forBubbleLinkFormComponent.core-web/libs/block-editor/src/test.ts: Removed the entire file as it is no longer needed.Miscellaneous improvements:
core-web/libs/block-editor/src/test-setup.ts: Added a workaround for jsdom CSS parsing errors to improve test stability.core-web/libs/ui/src/lib/components/dot-asset-search/components/dot-asset-card-list/dot-asset-card-list.component.ts: ImportedCommonModuleto the component for better modularity. [1] [2]Checklist
Results
Original with issue
Screen.Recording.2024-08-20.at.2.07.59.PM.mov
Chrome
2024-09-05.16-32-31.mp4
Firefox
2024-09-05.16-42-39.mp4