Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update translations #26118

Open
wezell opened this issue Sep 15, 2023 · 6 comments · May be fixed by #26119
Open

Update translations #26118

wezell opened this issue Sep 15, 2023 · 6 comments · May be fixed by #26119
Labels
Gardening Day Team : Scout Triage Type : Task

Comments

@wezell
Copy link
Contributor

wezell commented Sep 15, 2023

Parent Issue

No response

Task

We need to update our translation files to include the language keys for many of our new features.

Proposed Objective

User Experience

Proposed Priority

Priority 2 - Important

Acceptance Criteria

No response

External Links... Slack Conversations, Support Tickets, Figma Designs, etc.

No response

Assumptions & Initiation Needs

No response

Quality Assurance Notes & Workarounds

No response

Sub-Tasks & Estimates

No response
wezell added a commit that referenced this issue Sep 15, 2023
@wezell
task: Update translations
4e3f3f5 
ref: #26118
@wezell wezell linked a pull request Sep 15, 2023 that will close this issue
Open
wezell added a commit that referenced this issue Sep 15, 2023
@wezell
task: Update translations
8b28fc8 
ref: #26118
@wezell wezell linked a pull request Sep 15, 2023 that will close this issue
task: Update translations #26119
Open
@github-actions GitHub Actions
Copy link

This issue is stale because it has been open 90 days with no activity. Remove stale label or comment or this will be closed in 30 days.

@github-actions github-actions bot added the stale label Dec 15, 2023
@fmontes
Copy link
Member

fmontes commented Jun 18, 2024

Double check the PR, fix and merge.

@fmontes fmontes moved this from New to Gardening Day Backlog in dotCMS - Product Planning Sep 6, 2024
@fmontes
Copy link
Member

fmontes commented Sep 6, 2024

This has a PR, can we merge it?

@wezell
Copy link
Contributor Author

wezell commented Sep 6, 2024

No, needs work

@nollymar
Copy link
Contributor

@wezell what is missing on that PR? are you still working on it?

@wezell
Copy link
Contributor Author

wezell commented Sep 20, 2024

There are places where the PR changes escaping for example - I am not sure if this is intentional or not. It might be alright, but we need someone to run the code and invoke a few different message to see if it works.

https://github.com/dotCMS/core/pull/26119/files#diff-37c731f80bd3cd7003de4fde51a30ff34606d1a8e95cf74681ba4b49e5c7d9e4L4567-L4569

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Gardening Day Team : Scout Triage Type : Task
Projects
dotCMS - Product Planning
Status: Gardening Day Backlog
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

task: Update translations dotCMS/core
3 participants
@fmontes @wezell @nollymar