Repository navigation
FURB143: Preserve identity for mutable fallbacks - #397
Open
dajiaohuang wants to merge 1 commit into
Open
dajiaohuang wants to merge 1 commit into
dajiaohuang wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #381
FURB143 currently suggests replacing empty mutable fallbacks such as
items or [],table or {}, andtags or set()with the left operand. When that operand is empty,orreturns the fallback object, while the replacement returns the original operand; the rewrite changes object identity and can change aliasing after mutation. This change only removes the mutable list/dict/set patterns; the existing immutable cases remain unchanged.The existing FURB143 fixture now keeps the mutable cases as no-finding examples and retains the valid immutable cases.
Validation:
run_refurbon the base reproduced all three mutable suggestions; on this candidate it omits them while retaining the immutable-string suggestion. The changed golden fixture also matches the production runner (Python 3.13.13, Mypy 1.15.0).refurbandtest --exclude 'test/data*').pytest test/test_checks.py::test_checkswas attempted on Windows but fails on the repository-wide golden path separator mismatch (Windows backslash paths vs POSIX slash paths in fixtures); isolating this test also falls below the suite's 100% coverage threshold. The changed fixture passes through productionrun_refurbwith only path separators normalized. Full suite/e2e/docs and hosted CI results are unverified.