Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

change log of prune when nothing is found to debug visibility #1431

Merged
merged 1 commit into from
Jun 7, 2024

Conversation

Makio64
Copy link
Contributor

@Makio64 Makio64 commented Jun 7, 2024

Currently the prune is used internally in many functions and it 'spam' the log especially when No unused properties found :

for example :

resample: 0.83ms
prune: Removed types... Node (29)
flatten: 1.13ms
prune: No unused properties found.
weldVertices: 8.36ms
prune: No unused properties found.
prune: No unused properties found.
simplifyMesh: 11.40ms
//etc...

after this change :

resample: 0.83ms
prune: Removed types... Node (29)
flatten: 1.13ms
weldVertices: 8.36ms
simplifyMesh: 11.40ms
//etc...

Currently the prune is used internally in many functions and it 'spam' the log especially when No unused properties found : 

for example : 
```
resample: 0.83ms
prune: Removed types... Node (29)
flatten: 1.13ms
prune: No unused properties found.
weldVertices: 8.36ms
prune: No unused properties found.
prune: No unused properties found.
simplifyMesh: 11.40ms
//etc...
```
Copy link
Owner

@donmccurdy donmccurdy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good call, thanks!

Somewhat related:

@donmccurdy donmccurdy merged commit 143e217 into donmccurdy:main Jun 7, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants