Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor channel search functionality in tdm_loader #28

Merged
merged 10 commits into from
Mar 28, 2024
Prev Previous commit
Next Next commit
Rename method get_channels to _get_channels in tdm_loader
The public `get_channels` function is renamed to the private method `_get_channels` in 'tdm_loader.py'. This is due to internal use only, to provide more clarity and prevent unintended external access.
espenenesNOV committed Mar 25, 2024
commit 5b006cb8cd28c1ef25bd1fd731f8438d508ed494
2 changes: 1 addition & 1 deletion tdm_loader/tdm_loader.py
Original file line number Diff line number Diff line change
@@ -170,7 +170,7 @@ def _get_usi_from_txt(txt):
return re.findall(r'id\("(.+?)"\)', txt)

@cache
def get_channels(self, group_id):
def _get_channels(self, group_id):
group = self._xml_chgs[group_id]
return {v: i for i, v in enumerate(re.findall(r'id\("(.+?)"\)', group.find("channels").text))}