Move bloom optimization to only RPC return #2610
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Djadih
requested review from
gameofpointers,
jdowning100 and
kiltsonfire
as code owners
Djadih
force-pushed
the
bloom-response-orchard
branch
from
16236e0 to
f796421
Compare
gameofpointers
approved these changes
May 7, 2025
jdowning100
reviewed
May 7, 2025
| "type": hexutil.Uint(tx.Type()), | ||
| } | ||
|
|
||
| if receipt.Bloom.CheckAllZeros() { |
Contributor
There was a problem hiding this comment.
The point of this API call is legacy support for eth_ namespace (legacy Ethereum API). Have you tested this with ethereum-specific tooling?
Contributor
Author
There was a problem hiding this comment.
Not with ethereum tooling. It was requested as is though I assume this was discussed when the feature was described.
Djadih
force-pushed
the
bloom-response-orchard
branch
from
f796421 to
dead055
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.