Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updates swagger-ui submodule to v3.20.9 #1304

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

curiousdev
Copy link

Updates swagger-ui submodule to v3.20.9

@curiousdev
Copy link
Author

curiousdev commented Feb 28, 2019

@domaindrivendev I'm reviewing the failing test below. Some assets are no longer included. Am I overlooking something?

Swashbuckle.Tests.SwaggerUi.SwaggerUiTests.It_returns_correct_asset_mime_type("http://tempuri.org/swagger/ui/css/typography-css","text/css")
[OK] http://tempuri.org/swagger/ui/css/typography-css => text/css
[OK] http://tempuri.org/swagger/ui/css/typography-css => text/css
=> Swashbuckle.Tests.SwaggerUi.SwaggerUiTests.It_returns_correct_asset_mime_type("http://tempuri.org/swagger/ui/images/logo_small-png","image/png")
[NotFound] http://tempuri.org/swagger/ui/images/logo_small-png => application/json
[NotFound] http://tempuri.org/swagger/ui/images/logo_small-png => application/json

@curiousdev
Copy link
Author

@domaindrivendev Are there remaining open items for the PR?

@M0ns1gn0r
Copy link

@domaindrivendev could you please check this PR, everyone wants the new UI :)

@winter3angle
Copy link

@domaindrivendev kindly take a look at this, there are some annoying bugs in ancient swagger-ui, like #1253

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants