Another improvement to CI flakiness.

dom96 · Dec 14, 2021 · 869eb42 · 869eb42
1 parent 70f7291
commit 869eb42
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 3 deletions.
diff --git a/tests/simpleLog.nim b/tests/simpleLog.nim
@@ -13,13 +13,14 @@ proc onRequest(req: Request): Future[void] =
     case req.path.get()
     of "/":
       info("Requested /")
-      flushFile(logFile)  # Only errors above lvlError auto-flush
       req.send("Hello World")
     else:
       info("Requested ", req.path.get())
       error("404")
       req.send(Http404)
 
+  flushFile(logFile)  # Only errors above lvlError auto-flush
+
 block:
   let settings = initSettings()
 

diff --git a/tests/tester.nim b/tests/tester.nim
@@ -84,7 +84,9 @@ proc tests() {.async.} =
     let client = newAsyncHttpClient()
     let resp = await client.get("http://localhost:8080")
     check resp.code == Http200
-    check logFilename.readLines() == @["INFO Requested /"]
+    let file = open(logFilename)
+    check "INFO Requested /" in file.readAll()
+    file.close()
 
   check tryRemoveFile(logFilename)
   await startServer("simpleLog.nim")
@@ -93,7 +95,11 @@ proc tests() {.async.} =
     let client = newAsyncHttpClient()
     let resp = await client.get("http://localhost:8080/404")
     check resp.code == Http404
-    check logFilename.readLines(2) == @["INFO Requested /404", "ERROR 404"]
+    let file = open(logFilename)
+    let contents = file.readAll()
+    file.close()
+    check "INFO Requested /404" in contents
+    check "ERROR 404" in contents
 
   check tryRemoveFile(logFilename)