abstract reduced functional #156
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dham
force-pushed
the
dham/abstract_reduced_functional
branch
from
c8727a2 to
08a7631
Compare
* pause_checkpointing() every time step * Do not clean the step 0 if not in timestep checkpoint
* Maintain order of blocks in TimeStep with an OrderedSet This introduces a new set implementation, OrderedSet. * Use dictionary as backing for OrderedSet * Use Python 3.10 compatible forward reference
…e cycle (#194) * Break OvertypedType -> BlockVariable -> OverloadedType reference cycle * Add OverloadedType.clear_block_variable * OverloadedType pickle fix, required by Firedrake EnsembleReducedFunctional
… dham/abstract_reduced_functional
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactor the reduced functional as a subclass of an abstract class with a more consistent interface.