Skip to content

Conversation

@KaneFreeman
Copy link
Member

Type: bug

The following has been addressed in the PR:

Description:

Current InputValidity meta and validity middleware do not invalidate when the required status of a field changes. This results in an outside trigger being required before the correct validity is captured.

This change, which is breaking, takes the expected required value and compares it to the required attribute on the HTMLFormElement node. If they do not match, it invalidates (same behavior as when the values do not match).

@KaneFreeman KaneFreeman added breaking change Indicates the issue/pull request would result in a breaking change next Issue/Pull Request for the next major version bug Something isn't working area: core Core labels Sep 30, 2019
@codecov
Copy link

codecov bot commented Jun 17, 2020

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 97.43%. Comparing base (1626e35) to head (15b22a7).
⚠️ Report is 332 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #546   +/-   ##
=======================================
  Coverage   97.43%   97.43%           
=======================================
  Files         117      117           
  Lines        6513     6515    +2     
  Branches     1479     1479           
=======================================
+ Hits         6346     6348    +2     
  Misses        167      167           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area: core Core breaking change Indicates the issue/pull request would result in a breaking change bug Something isn't working next Issue/Pull Request for the next major version

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant