Update test for CA with sequential serial numbers #4872
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The SerialNumberUpdateJob has been added to update the ranges for sequential serial numbers, similar to SerialNumberUpdateTask. The job can be scheduled to run automatically at specific times, or can be run immediately by calling pki ca-job-start, whereas the task only supports a fixed interval. An upgrade script has been added to add the default config params for SerialNumberUpdateJob into existing instances. In the future it might be possible to replace SerialNumberUpdateTask with SerialNumberUpdateJob automatically. https://github.com/dogtagpki/pki/wiki/Configuring-SerialNumberUpdateJob
pkispawn has been modified to provide more params to configure the sequential serial numbers in CA. The params can also be added for KRA if needed later. The test for CA with sequential serial numbers has been updated to perform more detailed steps and verification. The test will now use small ranges to make it easier to verify the changes in the CS.cfg and DS. The test will also use SerialNumberUpdateJob to update the ranges immediately instead of waiting for SerialNumberUpdateTask to run. A more complex test with CA clones will be added separately later.
|
fmarco76
approved these changes
Oct 8, 2024
|
@fmarco76 Thanks! I'll merge this now, but I'd like to add a test for the gap hopefully before we fix the issue. How do we actually reproduce the gap? Do we need to use an increment that doesn't match the begin and the end? Or is it something only happening with clones? |
|
|
Thanks! I'll see if I can tweak this test. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
pkispawnhas been modified to provide more params to configure the sequential serial numbers in CA. The params can also be added for KRA if needed later.The test for CA with sequential serial numbers has been updated to perform more detailed steps and verification. The test will now use small ranges to make it easier to verify the changes in the
CS.cfgand DS. The test will also useSerialNumberUpdateJobto update the ranges immediately instead of waiting forSerialNumberUpdateTaskto run.A more complex test with CA clones will be added separately later.
The
SerialNumberUpdateJobhas been added to update the ranges for sequential serial numbers, similar toSerialNumberUpdateTask. The job can be scheduled to run automatically at specific times, or can be run immediately by callingpki ca-job-start, whereas the task only supports a fixed interval.An upgrade script has been added to add the default config params for
SerialNumberUpdateJobinto existing instances. In the future it might be possible to replaceSerialNumberUpdateTaskwithSerialNumberUpdateJobautomatically.https://github.com/dogtagpki/pki/wiki/Configuring-SerialNumberUpdateJob