Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update test for pki ca-user-show #4870

Merged
merged 1 commit into from
Oct 3, 2024
Merged

Update test for pki ca-user-show #4870

merged 1 commit into from
Oct 3, 2024

Conversation

edewata
Copy link
Contributor

@edewata edewata commented Oct 3, 2024

The basic CA test has been updated to run pki ca-user-show with default API and API v2 then verify the access logs generated by these commands.

The AccountClient has been updated to use the API version from PKIClient.

The AccountServlet.logout() has been updated to return NO_CONTENT status for consistency with API v1.

The basic CA test has been updated to run pki ca-user-show
with default API and API v2 then verify the access logs
generated by these commands.

The AccountClient has been updated to use the API version
from PKIClient.

The AccountServlet.logout() has been updated to return
NO_CONTENT status for consistency with API v1.
@edewata edewata requested a review from fmarco76 October 3, 2024 14:14
Copy link
Member

@fmarco76 fmarco76 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link

sonarcloud bot commented Oct 3, 2024

@edewata
Copy link
Contributor Author

edewata commented Oct 3, 2024

@fmarco76 Thanks!

@edewata edewata merged commit a773182 into dogtagpki:master Oct 3, 2024
157 of 165 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants