Enable registry for ACME #4860
Merged
Enable registry for ACME #4860
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The default pki_registry_enable for ACME has been changed to True. This allows pkispawn and pkidestroy to create and remove ACME properly. The PKIDeployer.create_acme_subsystem() has been modified to create the registry. The remove_acme_subsystem() has been modified to remove the registry. The PKISubsystem.remove_registry() has been modified to check whether the files/folders exist before removing them in case the subsystem was created without registry. The test for ACME on separate instance has been modified to no longer create the server and NSS database before calling pkispawn. Some file/folder permissions have also changed due to these changes.
|
|
@fmarco76 Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The default
pki_registry_enablefor ACME has been changed toTrue. This allowspkispawnandpkidestroyto create and remove ACME properly.The
PKIDeployer.create_acme_subsystem()has been modified to create the registry. Theremove_acme_subsystem()has been modified to remove the registry.The
PKISubsystem.remove_registry()has been modified to check whether the files/folders exist before removing them in case the subsystem was created without registry.The test for ACME on separate instance has been modified to no longer create the server and NSS database before calling
pkispawn. Some file/folder permissions have also changed due to these changes.