Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix v2 problems #4836

Merged
merged 2 commits into from
Aug 27, 2024
Merged

Fix v2 problems #4836

merged 2 commits into from
Aug 27, 2024

Conversation

fmarco76
Copy link
Member

Running all CI upstream tests I found a couple of issue. After this fix API can switch to v2.

In case where the same combination of "method:path" match the routing
it was selected always the first.

E.g.: POST:{} and POST:retrieve from KRA `KeyServlet` was not working
because always the first was used.

Additionally, the routing of servlets and filters are the same and it is
not supported anymore filter routing to multiple method using "*" which
has never been used.
@fmarco76 fmarco76 requested a review from edewata August 27, 2024 13:35
Copy link

sonarcloud bot commented Aug 27, 2024

Copy link
Contributor

@edewata edewata left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@fmarco76
Copy link
Member Author

@edewata Thanks!

@fmarco76 fmarco76 merged commit 91484ea into dogtagpki:master Aug 27, 2024
147 of 157 checks passed
@fmarco76 fmarco76 deleted the FixV2Problems branch August 27, 2024 17:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants