Bug2221818-ocsp-unknownCA-addendum #4538
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
a couple things: - respond with Unknown when CA can't find cert in its db - added safety net Exception to return Unknown - minor debug message when CA signs an object that's not a cert fixes https://bugzilla.redhat.com/show_bug.cgi?id=2221818
edewata
approved these changes
Aug 10, 2023
| } catch (EBaseException e) { | ||
| // internal error | ||
| logger.debug(name + e.toString()); |
There was a problem hiding this comment.
Since this is an internal error, I'd suggest that we generate a proper error log to help troubleshooting, something like this:
logger.error("Unable to retrieve certificate: " + e.getMessage(), e);
This statement will show a user friendly error message for the admin and a stack trace for developers.
Comment on lines
1854
to
1858
| } catch (Exception e) { | ||
| // safety net | ||
| logger.debug(name + e.toString()); | ||
| certStatus = new UnknownInfo(); | ||
| } |
There was a problem hiding this comment.
Instead of adding another catch clause I think we can just replace the EBaseException with Exception in the previous clause.
minor adjustment for Exception and debug messages.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
a couple things:
fixes https://bugzilla.redhat.com/show_bug.cgi?id=2221818