Health check verify all clones

[fmarco76]

pki-healthcheck stop its activity in case a clone is not working and report the error. If multiple clones are configured the check should go ahead to verify the other clones.

With this fix all clones are verified during the health check.

[sonarcloud]

Kudos, SonarCloud Quality Gate passed!   

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

No Coverage information
No Duplication information

[edewata]

LGTM.

This is a separate discussion, feel free to merge the PR regardless. I'm actually not sure why we need to check the clones in the healthcheck tool. Usually a healthcheck tool is used by a monitoring system to see whether a service on a particular machine is running properly, and if not the monitoring system will restart that machine or spawn a new one. If each machine also checks other machines (i.e. clones), that means there is a lot of redundant checks which could slow down the overall performance.

[fmarco76]

I'm actually not sure why we need to check the clones in the healthcheck tool. Usually a healthcheck tool is used by a monitoring system to see whether a service on a particular machine is running properly, and if not the monitoring system will restart that machine or spawn a new one

I am not sure how it is used but I can imagine the pki-healthcheck can be easily integrated in the monitoring system to get status information of the service while other checks controls the involved machine are just up and running.

[fmarco76]

@edewata Thanks!

[ckelleyRH]

Part of the problem is that older systems can run checks against newer systems, which can have breaking API changes that cause the checks to fail. We have already had bug reports of this nature. We need to discuss with the IPA team, but we should either not support this or, if we do, it needs to be made more resilient to possible limitations of external systems.