Replace deprecated ssl.PROTOCOL_TLS in pki/client.py

[ckelleyRH]

Resolves #4512

I modified the suggested fix as we never used ssl.PROTOCOL_TLSv1_2, we should keep the fall-through behaviour to default to ssl.PROTOCOL_TLS as it does currently and use the newer protocol if available.

[ckelleyRH]

Looks like I broke installation, will investigate.

[edewata]

I think it failed because we disabled verification in PKIServer.is_running():
https://github.com/dogtagpki/pki/blob/master/base/server/python/pki/server/__init__.py#L378

[ckelleyRH]

I think it failed because we disabled verification in PKIServer.is_running(): https://github.com/dogtagpki/pki/blob/master/base/server/python/pki/server/__init__.py#L378

Yes, I removed the bit that was conditional on self.verify for testing and didn't put anything back in to replace it. As the verification checks are now default on, I inverted the logic of the self.verify check so that we explicitly disable rather than explicitly enable them.

[sonarcloud]

Kudos, SonarCloud Quality Gate passed!   

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

0.0% Coverage
0.4% Duplication

[edewata]

LGTM. I think we can ignore the unrelated TPS test failure.

[ckelleyRH]

Thanks @edewata , I gave it the "old man shouts at test" routine and merged!