Add support for cloning with CSR files #4516
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
edewata
force-pushed
the
install
branch
3 times, most recently
from
98c70fd
to
3dc80ac
Compare
Previously during cloning pkispawn would retrieve database params and system cert params (i.e. <subsystem>.<tag>.*) from the master. However, the clone actually already has most of these params (from pkispawn config file and PKCS dogtagpki#12 file) except for the CSRs (i.e. <subsystem>.<tag>.certreq). The code in PKIDeployer.setup_database() that retrieves the params from the master has been modified to retrieve only the database params and the CSRs (unless the clone already has the them). In the future it might be possible to not retrieve anything from the master at all. The configuration.py has been modified such that the code that imports the certs and CSRs from files (if provided) will run in all cases including cloning instead of just in specific cases. The installation doc has been updated to show the optional steps for installing CA clone with CSR files. The test for CA clone has been updated to create the secondary subsystem without CSR files like before, then create the tertiary subsystem with CSR files.
|
Kudos, SonarCloud Quality Gate passed!
|
|
@ckelleyRH @fmarco76 Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously during cloning
pkispawnwould retrieve database params and system cert params (i.e.<subsystem>.<tag>.*) from the master. However, the clone actually already has most of these params (frompkispawnconfig file and PKCS #12 file) except for the CSRs (i.e.<subsystem>.<tag>.certreq).The code in
PKIDeployer.setup_database()that retrieves the params from the master has been modified to retrieve only the database params and the CSRs (unless the clone already has them). In the future it might be possible to not retrieve anything from the master at all.The
configuration.pyhas been modified such that the code that imports the certs and CSRs from files (if provided) will run in all cases including cloning instead of just in specific cases.The installation doc has been updated to show the optional steps for installing CA clone with CSR files:
https://github.com/edewata/pki/blob/install/docs/installation/ca/Installing_CA_Clone.md
The test for CA clone has been updated to create the secondary subsystem without CSR files like before, then create the tertiary subsystem with CSR files.