Update PKI_VERSION in tomcat.conf #4510
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ckelleyRH
approved these changes
Jul 21, 2023
base/common/python/pki/__init__.py
Outdated
Comment on lines
589
to
590
| length = len(self.quote) | ||
| value = value[length:-length] |
There was a problem hiding this comment.
Do we need to accept a case where there is more than one quotation character, e.g. ""[application_version]""?
If not, then this can simplify to value = value[1:-1] - and in the other places.
There was a problem hiding this comment.
Python does support triple quotes (''' or """) but I guess we don't really need to support that. I've added a code to check the quote length and changed the quote removal like you described.
The PKI_VERSION in tomcat.conf has been modified to use quotes like other properties in the file so they all can be processed more consistently. The PropertyFile and PKIUpgradeTracker classes have been modified to support optional quotes.
|
Kudos, SonarCloud Quality Gate passed!
|
|
@ckelleyRH Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
PKI_VERSIONintomcat.confhas been modified to use quotes like other properties in the file so they all can be processed more consistently.The
PropertyFileandPKIUpgradeTrackerclasses have been modified to support optional quotes.