Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update KRA servlets to use @WebServlet #4509

Merged
merged 15 commits into from
Jul 21, 2023
Merged

Conversation

edewata
Copy link
Contributor

@edewata edewata commented Jul 20, 2023

No description provided.

@sonarcloud
Copy link

sonarcloud bot commented Jul 20, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

Copy link
Contributor

@ckelleyRH ckelleyRH left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ckelleyRH
Copy link
Contributor

I re-ran the CI because there were several failures but I don't expect it will help, as there were a few recurring issues across tests like cloning.

Copy link
Member

@fmarco76 fmarco76 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ckelleyRH
Copy link
Contributor

I re-ran the CI because there were several failures but I don't expect it will help, as there were a few recurring issues across tests like cloning.

Well look at that, it passed this time! No idea what was wrong the first time then.

@edewata
Copy link
Contributor Author

edewata commented Jul 21, 2023

@ckelleyRH @fmarco76 Thanks! Yeah, sometimes a bunch of the tests failed for no reason and worked again after restart.

@edewata edewata merged commit 86613f1 into dogtagpki:master Jul 21, 2023
139 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants