Adding useful OCSP debug messages #4503
Conversation
| mCRLs.put(caCert, crl); | ||
| logger.debug("LDAPStore: updateCRLHash: mCRLs size=", Integer.toString(mCRLs.size())); |
There was a problem hiding this comment.
I think it should be written like this:
logger.debug("LDAPStore: updateCRLHash: mCRLs size={}", mCRLs.size());
or this:
logger.debug("LDAPStore: updateCRLHash: mCRLs size=" + mCRLs.size());
https://www.slf4j.org/api/org/slf4j/Logger.html#debug-java.lang.String-java.lang.Object-
https://www.slf4j.org/api/org/slf4j/helpers/MessageFormatter.html
There was a problem hiding this comment.
OH, I know my mistake now. It's '+' not ','. Silly me! Thanks! I'll make correction.
| @@ -399,11 +405,11 @@ public SingleResponse processRequest(Request req) throws Exception { | |||
| } | |||
|
|
|||
| if (theCert == null) { | |||
| throw new Exception("Missing issuer certificate"); | |||
| throw new Exception("Issuer certificate not found/served in mCRL"); | |||
There was a problem hiding this comment.
Exception messages are meant for users, not developers, so I'd suggest not to use an internal variable name like mCRL.
| } | ||
|
|
||
| if (theCRL == null) { | ||
| throw new Exception("Missing CRL data"); | ||
| throw new Exception("Missing CRL data for issuing CA:" + theCert.getSubjectDN().toString()); |
There was a problem hiding this comment.
The .toString() is redundant.
| mCRLs.put(caCert, crl); | ||
| logger.debug("LDAPStore: updateCRLHash: mCRLs size=", Integer.toString(mCRLs.size())); |
There was a problem hiding this comment.
btw, I originally simply said logger.debug("LDAPStore: updateCRLHash: mCRLs size=", mCRLs.size()); but it printed out nothing. After changing the code like above, I still got nothing in the debug log. It shows the following in the debug log: LDAPStore: updateCRLHash: mCRLs size=
Any idea?
| mCRLs.put(caCert, crl); | ||
| logger.debug("LDAPStore: updateCRLHash: mCRLs size=", Integer.toString(mCRLs.size())); |
There was a problem hiding this comment.
OH, I know my mistake now. It's '+' not ','. Silly me! Thanks! I'll make correction.
This patch fixed and added some useful information in the OCSP area. During investigation setup procedure for ticket RHCS-4264, some debug messages can be confusing. In addition, more information should be shared for administrators to understand why things are not working as expected. It is also useful for RHCS-4261 for RHCS-4264 and RHCS-4261
This patch fixed and added some useful information in the OCSP area. During investigation setup procedure for ticket RHCS-4264, some debug messages can be confusing. In addition, more information should be shared for administrators to understand why things are not working as expected.
for https://issues.redhat.com/browse/RHCS-4264