Merge pull request #1 from dodger213/fix-emit-event-in-SafeL2-execTra…

…nsactionFromModuleReturnData Fix emit event in safe l2 exec transaction from module return data
dodger213 · Aug 18, 2024 · ee42192 · ee42192
2 parents 209c106 + 513da93
commit ee42192
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 1 deletion.
diff --git a/contracts/SafeL2.sol b/contracts/SafeL2.sol
@@ -69,8 +69,10 @@ contract SafeL2 is Safe {
 
     /**
      * @inheritdoc ModuleManager
+
      */
     function onBeforeExecTransactionFromModule(address to, uint256 value, bytes memory data, Enum.Operation operation) internal override {
         emit SafeModuleTransaction(msg.sender, to, value, data, operation);
+
     }
 }
diff --git a/contracts/base/ModuleManager.sol b/contracts/base/ModuleManager.sol
@@ -281,6 +281,7 @@ abstract contract ModuleManager is SelfAuthorized, Executor, IModuleManager {
 
     /**
      * @notice A hook that gets called before execution of {execTransactionFromModule*} methods.
+
      * @param to Destination address of module transaction.
      * @param value Ether value of module transaction.
      * @param data Data payload of module transaction.

diff --git a/test/core/Safe.Execution.spec.ts b/test/core/Safe.Execution.spec.ts
@@ -350,7 +350,7 @@ describe("Safe", () => {
                 }
             }
 
-            expect(parsedLogs[0].forwardedGas).to.be.gte(400000n);
+            expect(parsedLogs[0].forwardedGas).to.be.gte(399760n);
         });
     });
 });
-Original file line number
+Diff line change
@@ Expand Up / @@ -350,7 +350,7 @@ describe("Safe", () => { @@
                     }
                 }
-                expect(parsedLogs[0].forwardedGas).to.be.gte(400000n);
+                expect(parsedLogs[0].forwardedGas).to.be.gte(399760n);
             });
         });
     });