Deprecate WITH in joined associations #10979
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
greg0ire
reviewed
Oct 10, 2023
lib/Doctrine/ORM/Query/Parser.php
Outdated
| Deprecation::trigger( | ||
| 'doctrine/orm', | ||
| 'https://github.com/doctrine/orm/issues/10978', | ||
| 'WITH join conditions are deprecated for joins on associations. Use either a sub-select with another occurance of this table or use Collection::matching(Criteria) in follow-up code.' |
There was a problem hiding this comment.
Suggested change
| 'WITH join conditions are deprecated for joins on associations. Use either a sub-select with another occurance of this table or use Collection::matching(Criteria) in follow-up code.' | |
| 'WITH join conditions are deprecated for joins on associations. Use either a sub-select with another occurrence of this table or use Collection::matching(Criteria) in follow-up code.' |
|
Looks good regarding the In order to fix #10978, we additionally need to take care of WHERE expressions referring to fetch-join aliases. |
|
@mpdude ah yes, I checked that - and its not possible, because you don't really know how its used. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Deprecates
JOIN path.association WITHtype of expressions as they create persistent collections with a subset of related entities and look like they are fully loaded, causing all kinds of trouble.A user could potentially work around this and move the condition to the
WHEREclause. I checked the code and its not really possible in this case to detect it without adding tons of more code. So the WITH deprecation is what we can do about this.Fixes #10978