Update "Custom Mapping Types" documentation for a fully working example #2778
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GromNaN
requested changes
Jun 10, 2025
| } | ||
|
|
||
| public function convertToDatabaseValue($value): array | ||
| { | ||
| if (! isset($value['utc'], $value['tz'])) { | ||
| throw new RuntimeException('Database value cannot be converted to date with timezone. Expected array with "utc" and "tz" keys.'); | ||
| if (!$value instanceof \DateTimeImmutable) { |
There was a problem hiding this comment.
Any DateTimeInterface would be accepted here.
Suggested change
| if (!$value instanceof \DateTimeImmutable) { | |
| if (!$value instanceof \DateTimeInterface) { |
There was a problem hiding this comment.
Indeed but it will not work with a \DateTime Document field for example because ::convertToPHPValue() returns a \DateTimeImmutable anyway.
Enforcing only one type in the two conversion is better IMO.
fnash
force-pushed
the
fna/update-custom-type-documentation
branch
from
d19a89c to
eae430b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Update "Custom Mapping Types" documentation for a fully working example of
DateTimeWithTimezoneType