Require PHP 8.1 #2556
Merged
Require PHP 8.1 #2556
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
malarzm
force-pushed
the
require-php-8-1
branch
from
55ae096
to
8dd2e91
Compare
malarzm
force-pushed
the
require-php-8-1
branch
from
8dd2e91
to
10b2ea7
Compare
malarzm
commented
Oct 23, 2023
| @@ -57,11 +57,6 @@ public static function mappingNotFoundByDbName(string $className, string $dbFiel | |||
| return new self(sprintf("No mapping found for field by DB name '%s' in class '%s'.", $dbFieldName, $className)); | |||
| } | |||
|
|
|||
| public static function duplicateFieldMapping(string $document, string $fieldName): self | |||
There was a problem hiding this comment.
Technically these removals are BC breaks but come on :)
There was a problem hiding this comment.
Are all those factories unused? o.O
There was a problem hiding this comment.
Yup. I was surprised a bit but figured they were just leftovers. Haven't investigated the reason tho
SenseException
approved these changes
Oct 24, 2023
This was referenced Oct 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Continuing #2546 (comment)