Merge pull request #19 from doctrine/GH-17-VerifyNoDeprecations

[GH-17] Allow verify deprecation was not triggered in test.
doctrine · Mar 11, 2021 · 011e779 · 011e779
2 parents 693916c + 269e9a9
commit 011e779
Show file tree

Hide file tree

Showing 2 changed files with 56 additions and 0 deletions.
diff --git a/lib/Doctrine/Deprecations/PHPUnit/VerifyDeprecations.php b/lib/Doctrine/Deprecations/PHPUnit/VerifyDeprecations.php
@@ -13,11 +13,19 @@ trait VerifyDeprecations
     /** @var array<string,int> */
     private $doctrineDeprecationsExpectations = [];
 
+    /** @var array<string,int> */
+    private $doctrineNoDeprecationsExpectations = [];
+
     public function expectDeprecationWithIdentifier(string $identifier): void
     {
         $this->doctrineDeprecationsExpectations[$identifier] = Deprecation::getTriggeredDeprecations()[$identifier] ?? 0;
     }
 
+    public function expectNoDeprecationWithIdentifier(string $identifier): void
+    {
+        $this->doctrineNoDeprecationsExpectations[$identifier] = Deprecation::getTriggeredDeprecations()[$identifier] ?? 0;
+    }
+
     /**
      * @after
      */
@@ -34,5 +42,17 @@ public function verifyDeprecationsAreTriggered(): void
                 )
             );
         }
+
+        foreach ($this->doctrineNoDeprecationsExpectations as $identifier => $expectation) {
+            $actualCount = Deprecation::getTriggeredDeprecations()[$identifier] ?? 0;
+
+            $this->assertTrue(
+                $actualCount === $expectation,
+                sprintf(
+                    "Expected deprecation with identifier '%s' was triggered by code executed in test, but expected not to.",
+                    $identifier
+                )
+            );
+        }
     }
 }
diff --git a/tests/Doctrine/Deprecations/VerifyDeprecationsTest.php b/tests/Doctrine/Deprecations/VerifyDeprecationsTest.php
@@ -0,0 +1,36 @@
+<?php
+
+declare(strict_types=1);
+
+namespace Doctrine\Deprecations;
+
+use Doctrine\Deprecations\PHPUnit\VerifyDeprecations;
+use PHPUnit\Framework\TestCase;
+
+class VerifyDeprecationsTest extends TestCase
+{
+    use VerifyDeprecations;
+
+    /**
+     * @before
+     */
+    public function setUpDisableDeprecations(): void
+    {
+        // prevent PHPUnit from throwing Deprecation exception in case trigger_error was enabled before
+        Deprecation::disable();
+    }
+
+    public function testExpectDeprecationWithIdentifier(): void
+    {
+        $this->expectDeprecationWithIdentifier('http://example.com');
+
+        Deprecation::trigger('doctrine/dbal', 'http://example.com', 'message');
+    }
+
+    public function testExpectNoDeprecationWithIdentifier(): void
+    {
+        $this->expectNoDeprecationWithIdentifier('http://example.com');
+
+        Deprecation::trigger('doctrine/dbal', 'http://otherexample.com', 'message');
+    }
+}