Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add CTE support to select in QueryBuilder #6621
Add CTE support to select in QueryBuilder #6621
Changes from all commits
6559c32
11280cd
19b6ad3
aab2338
3fdc8d8
b20f5e6
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
Check warning on line 37 in src/Platforms/MySQL80Platform.php
Codecov / codecov/patch
src/Platforms/MySQL80Platform.php#L37
Check warning on line 40 in src/Platforms/MySQL80Platform.php
Codecov / codecov/patch
src/Platforms/MySQL80Platform.php#L39-L40
Check warning on line 42 in src/Platforms/MySQLPlatform.php
Codecov / codecov/patch
src/Platforms/MySQLPlatform.php#L42
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe if the outer builder will ignore the parameters bound to the inner one, it shouldn't accept
QueryBuilder
and should only acceptstring
? This way, the caller will have to calltoSql()
on the inner builder and thereby acknowledge that its parameters won't be used.