Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add space group as another layer as unions of spaces #72

Merged
merged 2 commits into from
Jul 22, 2023

Conversation

cwang
Copy link
Contributor

@cwang cwang commented Jul 21, 2023

Description

Introducing *space group as a persisted union of spaces, used internally and externally as a way to remove direct dependency on a single space.

Works similarly to how *user group works in admin section.

A part of the solution for #46

Also as a temporary fix for #65

(old screenshot before renaming showing the UI)
Screenshot 2023-07-21 at 16 42 08

(new screenshot showing the latest naming choices)
Screenshot 2023-07-21 at 22 23 34

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Refactor and code improvement (non-breaking change which improves code quality and/or performance)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation
  • Tests
  • Other chores such as maintenance

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration by modifying the list below.

  • Test A
  • Test B
  • Test C

Test Configuration:

Please describe the test setup. List them below as bullet points.

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules
  • I have checked my code and corrected any misspellings
  • The commit message follows the convention of this project

@cwang cwang marked this pull request as ready for review July 21, 2023 15:43
@cwang cwang requested a review from a team as a code owner July 21, 2023 15:43
@janaka
Copy link
Contributor

janaka commented Jul 21, 2023

Why call this "Engagement" and not "Space Union" or "Space Group"? for me personally it's not an intuitive name.

source/docq/manage_groups.py Outdated Show resolved Hide resolved
source/docq/setup.py Outdated Show resolved Hide resolved
@cwang cwang changed the title Add engagement as another layer as unions of spaces Add space group as another layer as unions of spaces Jul 21, 2023
@cwang
Copy link
Contributor Author

cwang commented Jul 21, 2023

Why call this "Engagement" and not "Space Union" or "Space Group"? for me personally it's not an intuitive name.

Renamed to user groups and space groups from implementations to UI and anywhere in between.

We may change them on UI with more marketing-friendly names in the future, but I agree that sticking to what they really are when naming them in implementations is the best way forward.

@cwang cwang merged commit 6d6c371 into main Jul 22, 2023
@cwang cwang deleted the feat/space-permissions-applied branch July 22, 2023 11:45
osala-eng pushed a commit that referenced this pull request Aug 22, 2023
* Add engagement as another layer as unions of spaces

* Rename globally to user groups and space groups
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants