Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/browsertools #1820

Merged
merged 2 commits into from
Jul 19, 2023
Merged

Feature/browsertools #1820

merged 2 commits into from
Jul 19, 2023

Conversation

coverbeck
Copy link
Contributor

@coverbeck coverbeck commented Jul 19, 2023

Description
Fix broken browser tools installation. See CircleCI-Public/browser-tools-orb#75.

Review Instructions
Builds on CircleCI should pass.

Issue
None

Security
If there are any concerns that require extra attention from the security team, highlight them here.

Please make sure that you've checked the following before submitting your pull request. Thanks!

  • Check that your code compiles by running npm run build
  • Ensure that the PR targets the correct branch. Check the milestone or fix version of the ticket.
  • If this is the first time you're submitting a PR or even if you just need a refresher, consider reviewing our style guide
  • Do not bypass Angular sanitization (bypassSecurityTrustHtml, etc.), or justify why you need to do so
  • If displaying markdown, use the markdown-wrapper component, which does extra sanitization
  • Do not use cookies, although this may change in the future
  • Run npm audit and ensure you are not introducing new vulnerabilities
  • Do due diligence on new 3rd party libraries, checking for CVEs
  • Don't allow user-uploaded images to be served from the Dockstore domain
  • If this PR is for a user-facing feature, create and link a documentation ticket for this feature (usually in the same milestone as the linked issue). Style points if you create a documentation PR directly and link that instead.
  • Check whether this PR disables tests. If it legitimately needs to disable a test, create a new ticket to re-enable it in a specific milestone.

@coverbeck
Copy link
Contributor Author

Note: accessiblity_test_base is failing because master is pointing to expired CircleCi artifacts

@coverbeck coverbeck merged commit 4ad2ce4 into hotfix/2.11.1 Jul 19, 2023
13 of 15 checks passed
@coverbeck coverbeck deleted the feature/browsertools branch July 19, 2023 16:26
@coverbeck coverbeck restored the feature/browsertools branch July 19, 2023 16:52
@coverbeck coverbeck deleted the feature/browsertools branch July 19, 2023 17:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants