Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SEAB-6957: Documentation for delete entry feature #264

Merged
merged 10 commits into from
Jan 31, 2024
Merged
Show file tree
Hide file tree
Changes from 9 commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
46 changes: 46 additions & 0 deletions docs/getting-started/delete-on-dockstore.rst
Original file line number Diff line number Diff line change
@@ -0,0 +1,46 @@
Deleting an Entry on Dockstore
===================================

Tutorial Goals
--------------

- Deleting an entry
- Ensuring that the entry does not re-appear on Dockstore

This tutorial walks through the process of deleting entries from Dockstore.
This action is permanent and after you delete the workflow, it will no longer appear on Dockstore.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: You're following the dialog text, where I should have noticed it earlier, but it seems little dissonant to on the one hand say it's permanent and will no longer appear on Dockstore, and then there is a section below on how to ensure is doesn't appear again -- that's not permanent. :)

Not sure I have an easy rephrasing in mind, so just something to ponder, and if no other idea comes, ok to leave.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Kept line to keep consistent with dialog

hyunnaye marked this conversation as resolved.
Show resolved Hide resolved

Requirements for Deletion
-------------------------

An entry can only be deleted if it satisfies all the following:
hyunnaye marked this conversation as resolved.
Show resolved Hide resolved

- Has never been published,
- Was created on/after April 1, 2022,
- Is not a checked or checker workflow, and
- If registered via GitHub Apps, the entry is removed from the ``.dockstore.yml`` file or the Dockstore GitHub App is uninstalled from the source GitHub repo.

If your entry does not meet the requirements above, you can archive it using these steps.
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll link the documentation page for archiving in my next PR for https://ucsc-cgl.atlassian.net/browse/SEAB-5979


Deleting an Entry
------------------

Navigate to ``/my-tools``, ``/my-workflows``, ``/my-notebooks``, or ``/my-services`` by going to My Dashboard then selecting the desired option in the left sidebar.
In the sidebar accordion, find the GitHub repository that your entry is in and click the entry you would like to delete.

.. image:: /assets/images/docs/sidebar-accordian-workflow-select.png
:width: 50 %

You should now see your entry with the Delete button on the far right of the page. Click the Delete button.

.. image:: /assets/images/docs/workflow-showing-delete-button.png
:width: 50 %

Read the dialog message and if you are sure you would like to delete, click the Delete this workflow/tool/notebook/service button

.. image:: /assets/images/docs/delete-workflow-dialog.png
:width: 50 %

Please make sure that you have uninstalled the Dockstore GitHub App from the source GitHub repo, or edited/removed the ``.dockstore.yml`` file so that it no longer describes the deleted entry.
If you do not, your deleted entry may reappear on Dockstore the next time you push to the repo.

4 changes: 3 additions & 1 deletion docs/index.rst
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,8 @@ Getting Started
4. :doc:`Creating a Dockstore Account <getting-started/register-on-dockstore>`
5. :doc:`Register a tool on Dockstore <getting-started/dockstore-tools>`
6. :doc:`Register a workflow on Dockstore <getting-started/dockstore-workflows>`
7. :doc:`Hosted tools and workflows <getting-started/hosted-tools-and-workflows>`
7. :doc:`Delete an Entry on Dockstore <getting-started/delete-on-dockstore>`
8. :doc:`Hosted tools and workflows <getting-started/hosted-tools-and-workflows>`
* :doc:`Notebooks <getting-started/getting-started-with-notebooks>`
* :doc:`Services (preview) <getting-started/getting-started-with-services>`
* :doc:`Registering tools, workflows, notebooks, and services with the Dockstore GitHub App <getting-started/github-apps/github-apps-landing-page>`
Expand All @@ -63,6 +64,7 @@ Getting Started
getting-started/register-on-dockstore
getting-started/dockstore-tools
getting-started/dockstore-workflows
getting-started/delete-on-dockstore
getting-started/hosted-tools-and-workflows
getting-started/getting-started-with-services
getting-started/getting-started-with-notebooks
Expand Down