Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/java 21 #293

Draft
wants to merge 10 commits into
base: develop
Choose a base branch
from
Draft

Feature/java 21 #293

wants to merge 10 commits into from

Conversation

denis-yuen
Copy link
Member

@denis-yuen denis-yuen commented Aug 13, 2024

Description
Make the CLI build compatible with Java 21.
Does not switch to only Java 21, yet

Review Instructions
Describe if this ticket needs review and if so, how one may go about it in qa and/or staging environments.
For example, a ticket based on Security Hub, Snyk, or Dependabot may not need review since those services
will generate new warnings if the issue has not been resolved properly. On the other hand, an infrastructure
ticket that results in visible changes to the end-user will definitely require review.
Many tickets will likely be between these two extremes, so some judgement may be required.

Issue
https://ucsc-cgl.atlassian.net/browse/SEAB-6611

Security
If there are any concerns that require extra attention from the security team, highlight them here.

Please make sure that you've checked the following before submitting your pull request. Thanks!

  • Check that you pass the basic style checks and unit tests by running ./mvnw clean install
  • If this PR is for a user-facing feature, create and link a documentation ticket for this feature (usually in the same milestone as the linked issue). Style points if you create a documentation PR directly and link that instead.

@denis-yuen denis-yuen self-assigned this Aug 13, 2024
@github-advanced-security
Copy link

This pull request sets up GitHub code scanning for this repository. Once the scans have completed and the checks have passed, the analysis results for this pull request branch will appear on this overview. Once you merge this pull request, the 'Security' tab will show more code scanning analysis results (for example, for the default branch). Depending on your configuration and choice of analysis tool, future pull requests will be annotated with code scanning analysis results. For more information about GitHub code scanning, check out the documentation.

Copy link

sonarcloud bot commented Aug 13, 2024

Copy link

codecov bot commented Aug 13, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 70.01%. Comparing base (b19b60e) to head (69e685e).

Additional details and impacted files
@@              Coverage Diff              @@
##             develop     #293      +/-   ##
=============================================
- Coverage      70.25%   70.01%   -0.25%     
+ Complexity      1074     1059      -15     
=============================================
  Files             47       47              
  Lines           6069     6069              
  Branches         801      801              
=============================================
- Hits            4264     4249      -15     
- Misses          1470     1475       +5     
- Partials         335      345      +10     
Flag Coverage Δ
bitbuckettests 9.83% <ø> (ø)
confidentialtooltests 55.54% <ø> (-0.35%) ⬇️
confidentialworkflowtests 30.23% <ø> (-0.04%) ⬇️
nonconfidentialtests 32.27% <ø> (-0.14%) ⬇️
singularitytests 16.59% <ø> (ø)
unittests 8.35% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant