Updated README.md #288
Closed
Updated README.md #288
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dockersamples#280 Added the official image locations of Voting-app , Result-app and the worker
|
How about not replacing the links to where the source lives, and just adding (image) with a link to each line? |
|
Instead of adding an image to the line, folks can look into the Dockerfile for each of the services. If we wanted to provide more information about how each service works, I'd recommend we either add a section in the README about each service or create a separate README for each service in their respective folders. As such, we aren't going to merge this PR, but am happy to talk further about the other approaches and ideas if you still feel they are needed @AtriChatterjee1. If so, feel free to create an issue and we'll chat from there! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#280
Added the official docker image locations of voting-app , result-app and the worker in the README.md