Skip to content

dmr: plugin install #22664

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 7 commits into
base: main
Choose a base branch
from

Conversation

ArthurFlag
Copy link
Contributor

Description

Add DMR Docker Engine plugin install cmd.

Related issues or tickets

Reviews

  • Technical review
  • Editorial review
  • Product review

Copy link

netlify bot commented May 19, 2025

Deploy Preview for docsdocker ready!

Name Link
🔨 Latest commit 9a09b06
🔍 Latest deploy log https://app.netlify.com/projects/docsdocker/deploys/68304d425769050008708757
😎 Deploy Preview https://deploy-preview-22664--docsdocker.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@github-actions github-actions bot added hugo Updates related to hugo area/tests area/ai labels May 19, 2025
Comment on lines 64 to 65
$ sudo yum update
$ sudo yum install docker-model-runner
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think all rpm-based distros we support have moved to dnf, so we can use

$ sudo dnf update
$ sudo dnf install docker-model-runner

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, we have other docs referring to yum, I'll take a pass 🙇

@ArthurFlag ArthurFlag force-pushed the ENGDOCS-2619-dmr-for-docker-ce branch from ad2427a to 7529175 Compare May 20, 2025 16:54
@ArthurFlag ArthurFlag requested a review from kiview May 21, 2025 19:39
Copy link

@xenoscopic xenoscopic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just had a few minor ideas.

@@ -42,6 +44,36 @@ Models are pulled from Docker Hub the first time they're used and stored locally

You can now use the `docker model` command in the CLI and view and interact with your local models in the **Models** tab in the Docker Desktop Dashboard.

### Enable DMR in Docker Engine

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure the official branding that we're using for our packaged version of Moby, but I think we're offering new support options specifically for "Docker CE", so that may be the terminology we want to use here and elsewhere.

However, I know the rest of the docs use Docker Engine, so probably better to stay consistent for now. Maybe we should seek clarity though. In the code, we generally use the "Moby" terminology.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants