Skip to content

fix: use correct variable metrics-addr #22616

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
+1 −1
Open

fix: use correct variable metrics-addr #22616

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion content/manuals/engine/daemon/prometheus.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@ instance using Prometheus.
### Configure the daemon

To configure the Docker daemon as a Prometheus target, you need to specify the
`metrics-address` in the `daemon.json` configuration file. This daemon expects
`metrics-addr` in the `daemon.json` configuration file. This daemon expects
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I went checking, but looks like metrics-addr is the correct name of the field in the daemon.json configuration file;
https://github.com/moby/moby/blob/7979b3d46b20316da9a7966d610e1e75bf3297c0/daemon/config/config.go#L241

MetricsAddress string `json:"metrics-addr"`

the file to be located at one of the following locations by default. If the
file doesn't exist, create it.

Expand Down