Skip to content

Fix shell script vulnerabilities #416

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

sundanc
Copy link

@sundanc sundanc commented Mar 21, 2025

- What I did

Fixed two shell script vulnerabilities that could lead to unexpected behavior.

- How I did it

  • Added the missing pipefail argument to the -o flag in scripts/validate/fileheader
  • Changed checkout $* to checkout "$@" in scripts/checkout.sh to properly handle arguments with spaces

- How to verify it

  • Test the validate script to ensure it behaves correctly on pipeline failures
  • Test the checkout script with arguments containing spaces to verify they are handled correctly

- Description for the changelog

Fixed shell script vulnerabilities in validate/fileheader and checkout.sh scripts.

- Fix incomplete shell option in validate/fileheader script

- Fix unsafe parameter handling in checkout.sh

Signed-off-by: sundance <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants