fix(publish): detect named volumes with driver_opts bind in checkForBindMount#13702
Open
ishwar170695 wants to merge 3 commits intodocker:mainfrom
Open
fix(publish): detect named volumes with driver_opts bind in checkForBindMount#13702ishwar170695 wants to merge 3 commits intodocker:mainfrom
ishwar170695 wants to merge 3 commits intodocker:mainfrom
Conversation
…indMount Signed-off-by: Ishwar <ishwarcm@iitbhilai.ac.in>
Contributor
There was a problem hiding this comment.
Pull request overview
Extends publish pre-checks to warn users when a named volume is actually a bind mount via driver_opts (e.g., local driver with o=bind and device=/host/path), preventing accidental host-path leakage into OCI artifact metadata.
Changes:
- Updated
checkForBindMountto detect bind mounts declared through top-level named volumedriver_opts. - Added
isDriverOptsBindhelper to identify bind/rbind options safely (avoiding substring false-positives likenobind). - Added unit tests for named-volume bind detection and table-driven coverage for
isDriverOptsBind.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| pkg/compose/publish.go | Detects driver_opts-based bind mounts for named volumes and surfaces them in the publish prompt. |
| pkg/compose/publish_test.go | Adds tests covering named-volume bind detection and option parsing edge cases. |
| h --force-with-lease | Appears to be an accidentally committed scratch/artifact file (should not be in the repo). |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Signed-off-by: Ishwar <ishwarcm@iitbhilai.ac.in>
Signed-off-by: Ishwar <ishwarcm@iitbhilai.ac.in>
Contributor
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 2 out of 2 changed files in this pull request and generated no new comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
checkForBindMountonly flagsVolumeTypeBindentries directly inservice.volumes. A named volume (VolumeTypeVolume) whose top-level definition usesdriver: localwithdriver_opts(o: bind,device: /host/path) bypasses the check entirely, the host path leaks into the OCI artifact metadata without any user warning.Reproducer: compose.yaml
Before this fix: compose publish proceeds with no prompt.
After this fix: user is warned and must confirm.
Fix
Extended
checkForBindMountto also walkproject.Volumesfor named volume references and detectdriver_optsbind mounts via a newisDriverOptsBindhelper. The helper splits theofield on commas to avoid false positives likenobind.Tests
Added
Test_checkForBindMount_namedVolume_driverOptsBindand a table-drivenTest_isDriverOptsBindcovering plain bind, rbind, comma-separated options, nobind false positive, missing device key, and non-local driver.(not mandatory) A picture of a cute animal, if possible in relation to what you did