Conversation
Signed-off-by: Alexandre Rodrigues <alexandre3ylf@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
--mount type=volume,target=/data,bind-recursive=enabledsilently accepts a bind-only option. Theenabledbranch does not initializeBindOptions, so it bypasses the existing check that rejects mixing bind options with other mount types.Initialize the default bind options for explicit
bind-recursive=enabled, allowing the existing final validation to reject incompatible mount types regardless of field order. Add regression cases for volume, implicit volume, tmpfs, and image mounts, and update the valid bind-mount expectation.Validation:
golangci-lint v2.13.2 run ./opts/...passes.bind-recursive=enabledstill creates and starts successfully.Release notes (optional)