[29.x backport] cli/command: add missing "go:build" comments#6884
Merged
thaJeztah merged 1 commit intodocker:29.xfrom Mar 25, 2026
Merged
[29.x backport] cli/command: add missing "go:build" comments#6884thaJeztah merged 1 commit intodocker:29.xfrom
thaJeztah merged 1 commit intodocker:29.xfrom
Conversation
- commit e8dc2fc modernized loops to range over int, which requires go1.22 or later. - commit 85ebca5 modernized code to use stdlib min/max, which requires go1.21 or later. Signed-off-by: Sebastiaan van Stijn <github@gone.nl> (cherry picked from commit 9a47118) Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
thaJeztah
added
impact/changelog
status/2-code-review
kind/bugfix
vvoland
approved these changes
Mar 25, 2026
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
cli/command: add missing "go:build" comments
- Human readable description for the release notes
- A picture of a cute animal (not mandatory but encouraged)