Add linux/riscv64 to bin-image-cross release target#6858
Add linux/riscv64 to bin-image-cross release target#6858thaJeztah merged 1 commit intodocker:masterfrom
Conversation
Add linux/riscv64 to the bin-image-cross platforms list so that official release images include riscv64 binaries. riscv64 is already present in the _platforms variable (line 38) and used by the cross, dynbinary-cross, and plugins-cross targets. CI already builds riscv64 binaries, but they are excluded from the release image because bin-image-cross has its own platform list. Closes docker#6857 Signed-off-by: Bruno Verachten <gounthar@gmail.com>
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
|
The
Could a maintainer please add the The riscv64 builds pass (both static and glibc variants). The other failing job ( |
|
Thanks! LGTM but it still won't make the official packages (hosted at https://download.docker.com/) include the riscv64 binaries. Our official release pipeline has an explicit list of targets which only includes amd64/arm architectures. |
|
Thanks for the context @vvoland — that makes sense. Regarding native runners: Cloud-V provides free self-hosted GitHub Actions runners on real riscv64 hardware to open source projects. For example, llama.cpp already uses Cloud-V runners for their native riscv64 CI jobs. Would Docker be open to exploring that option? If so, I can help with the initial setup and testing. Happy to open a separate issue to discuss adding riscv64 to the release pipeline once native runners are available. |
|
Thanks! Yes, no objection whatsoever to add it in the dockereng/cli-bin image. As Pawel mentioned; adding it to the download.docker.com package repo, and adding it in the release-pipeline there may be slightly more involved. Native runners could be an option, but we'd have to check (also because parts of the pipeline is private). We should look though if we can publish images containing the (cross-built) binaries as part or the https://github.com/docker/packaging repository. I thought we also pushed versions for tagged releases there, but at a quick glance, I only see nightly builds; https://hub.docker.com/r/dockereng/packaging/tags?name=cli (I may be mistaken there, but perhaps @vvoland recalls). |
- What I did
Added
linux/riscv64to thebin-image-crosstarget's platform list indocker-bake.hcl, so that official release images include riscv64 binaries.- How I did it
One-line addition to
docker-bake.hcl.linux/riscv64is already present in the_platformsvariable (line 38) and used by thecross,dynbinary-cross, andplugins-crosstargets — CI already builds riscv64 binaries. They are simply excluded from the release image becausebin-image-crosshas its own hardcoded platform list.- How to verify it
docker buildx bake bin-image-cross --printand confirmlinux/riscv64appears in the platforms list- Human readable description for the release notes
- A picture of a cute animal (not mandatory but encouraged)
🐧 (a riscv penguin)
Closes #6857