cli/command/container: improve CID-file errors#6758
Merged
vvoland merged 2 commits intodocker:masterfrom Jan 26, 2026
Merged
Conversation
Include the container-ID in the error message when failing to write the ID to a file, so that the user can still find the ID of the container that was created. Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
thaJeztah
commented
Jan 26, 2026
cli/command/container/create.go
Outdated
Comment on lines
180
to
181
Member
Author
There was a problem hiding this comment.
This can probably also be improved to ignore "not found" errors and probably remove the cid.path, because os.Remove returns a os.PathError
Ignore errors when trying to remove a CID-file that no longer exists; also remove the path from the custom error as os.Remove already returns a os.PathError, which includes the path. Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
thaJeztah
changed the title
vvoland
approved these changes
Jan 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
cli/command/container: cidFile.Write: include CID in error message
Include the container-ID in the error message when failing to write the ID to a file, so that the user can still find the ID of the container that was created.
cli/command/container: ignore "not found" error on cidfile.Close
Ignore errors when trying to remove a CID-file that no longer exists;
also remove the path from the custom error as os.Remove already returns
a os.PathError, which includes the path.
- Human readable description for the release notes
- A picture of a cute animal (not mandatory but encouraged)